Conversation
|
Find and replace tests fail on this one. But I want to test them manually. Maybe the tests are out of date as well. |
|
I downloaded the windows artifact from here: https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=317&view=artifacts&type=publishedArtifacts Find and replace works for me in one file. It does not work with your instructions atom#21079 (comment) However, in the settings view for one package, I cannot scroll using trackpad gestures. |
parallelize core tests allow requesting parallel tests for all OS run tests using async.parallel don't use temp.track() cleanup process fails when the file is locked (in parallel tests) warn before error reporting Helps visually test: use Azure format for printing Run windows renderer tests in parallel Run windows core main tests in the build step always upload atom windows.zip for x64 bootstrap in case cache misses macos: run core main tests in the build phase print the used testCommand for failed tests update message about finding a single application to run the tests
⬆️ etch@0.14.0
bump electron-link to 0.4.3
…into bump_electron_6
|
I cannot search for packages for downloading in the settings view. I wonder if this is caused by the recent settings view change. @DeeDeeG Can you reproduce this with the upstream branch instead?
|
|
I am going to close this as the upstream pull request is updated. |
|
I am willing to merge Electron 6 here ( Yet, is complicates our other PRs. But somebody's going to have to do it eventually. I think if we want to show upstream we're serious, this could be something to do here first. Any thoughts? Agree/disagree? (I wonder why upstream isn't merging it anyhow... Hmm. It seems ready to me.) Edit: If you want, we can just have a branch that's the "Electron 6 Take Two" PR floated (periodically rebased or Bonus: lets us do an experimental Electron 7 PR and start finding and clearing up the barriers to Electron 7 for ourselves and upstream when we get the time. |
|
I was thinking about that. Let me do it myself. I will delete some of these useless closed branches and will merge it! I love the Electron 7 idea! My next big thing is #67. You can work on electron 7 in parallel. Edit: Add the things you are working to Projects. I want us to keep track of the things there so things do not get lost even if we close pull requests. |
4 participants
We will not merge this. This is just an experiment, so do not review this.
Differences with upstream:
- I bumped vscode-ripgrep from 1.2.5 to 1.8: atom#21056