Conversation
cleanup process fails when the file is locked (in parallel tests)
Helps visually
|
Hmm. I'm not sure merging unrelated PRs into one-another through the GitHub UI like this is a good idea. Now the PR is closed and can't be re-opened. By merging this into For the sake of collaboration and review, I would encourage you to merge on the command-line if you want to see two sets of changes combined. And that they nonetheless should be merged into Separation of concerns makes a maintainer's life easier and preserves one's sanity. It is also polite toward any reviewer to not change the state of proposed PRs this drastically. It is early days for the fork, but setting up good habits early can pay off; by making them habitual, they become second-nature and you don't have to think about it anymore. Anyway, that's all subjective project maintenance philosophy. My two cents. |
|
We are not going to merge #48 to our master. That is just an experiment. I merged this to that one to save time. |
|
They are both your branches, so... I can't say I'm not confused, but I trust that you know what you're doing. |
2 participants
No description provided.