feat(BASE-422): make the Validity demo a read-only observer of the central AMM - #128
Merged
BrianBland merged 1 commit intoSep 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
✅ Heimdall Review Status
|
BrianBland
force-pushed
the
brianbland/base-422-vibenet-validity-central-actors
branch
from
September 2, 2026 20:02
141d804 to
a3e8ce7
Compare
BrianBland
changed the title
…tral AMM (BASE-422) The AMM pool and its maker flow now run on central vibenet infrastructure (the actor system), so the demo no longer runs actors in the browser. - Remove the client-side maker subaccounts, the startBots swap loop, and the client-side ensureSingleton pool deploy (+ the "Deploy shared pool" button). - Keep read-only probeSingleton discovery — deterministic CREATE2 means the browser rediscovers exactly what vibenet-setup deployed — plus the candle/ price display and the user's own inventory + conditional orders. - Show a "pool is coming online" state for the window before the actors are live. Delete the now-dead code the cutover leaves behind: - lib/bots.ts + lib/makers.ts (and their tests) — no longer referenced. - ensureSingleton() and its write-path helpers in lib/singleton.ts; keep the probeSingleton()/predictSingleton() read chain (still used + tested). - encodeSwapLegs() in lib/amm.ts (only the deleted bots.ts used it). - The now-unwritten accountId / makerAccountIds fields in the persisted store. Co-Authored-By: Claude <noreply@anthropic.com>
BrianBland
force-pushed
the
brianbland/base-422-vibenet-validity-central-actors
branch
from
September 3, 2026 00:20
a3e8ce7 to
3f7dbc1
Compare
haardikk21
approved these changes
Sep 3, 2026
BrianBland
deleted the
brianbland/base-422-vibenet-validity-central-actors
branch
September 3, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the vibenet-side actor system (parent BASE-418; infra PRs base/vibenet#32 → #33 → #34). Independent — base branch
main.The AMM pool and its maker flow now run on central vibenet infrastructure, so the demo no longer runs actors in the browser.
What
startBotsswap loop, and the client-sideensureSingletonpool deploy (+ the "Deploy shared pool" button).probeSingletondiscovery — deterministic CREATE2 means the browser rediscovers exactly whatvibenet-setupdeployed — plus the candle/price display and the user's own inventory + conditional orders.Verified
tsc --noEmitandeslintclean (remaining lint output is pre-existingreact-hooks/refswarnings on untouched lines).Notes
lib/bots.ts/lib/makers.tsare now unreferenced by the demo (kept in place; they were the porting source for the actor service).Linear
BASE-422