Skip to content

Fix toggle load order so user overrides take precedence#6116

Closed
axelfrache wants to merge 2 commits into
basecamp:devfrom
axelfrache:fix-toggle-load-order
Closed

Fix toggle load order so user overrides take precedence#6116
axelfrache wants to merge 2 commits into
basecamp:devfrom
axelfrache:fix-toggle-load-order

Conversation

@axelfrache

Copy link
Copy Markdown

Summary

  • Move require("default.hypr.toggles") before user require() calls in the hyprland.lua template
  • Add a migration that reorders existing hyprland.lua and hyprland.conf installs automatically

Toggles were loaded after user customizations, so any toggle would silently override settings in ~/.config/hypr/looknfeel.conf. The correct order is: Omarchy defaults → toggles → user config.

Fixes #6068

Copilot AI review requested due to automatic review settings June 21, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Hyprland toggle load ordering so user configuration reliably overrides toggle-provided settings, aligning behavior with the intended precedence: Omarchy defaults → toggles → user config.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Reorders require("default.hypr.toggles") in the Hyprland Lua template to run before user modules.
  • Adds a migration to automatically reorder existing ~/.config/hypr/hyprland.lua and ~/.config/hypr/hyprland.conf installs to preserve user override precedence.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
migrations/1780929365.sh Migrates existing Hyprland configs to the corrected toggle/user override load order.
config/hypr/hyprland.lua Updates the default Hyprland Lua template to load toggles before user modules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread migrations/1780929365.sh Outdated
Comment thread migrations/1780929365.sh Outdated
@dhh

dhh commented Jul 19, 2026

Copy link
Copy Markdown
Member

It seems correct to me that toggles would override user settings. That's the entire point. Otherwise we can't guarantee that, say, no borders actually does what we promise.

@dhh dhh closed this Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Omarchy toggle load order makes user looknfeel.conf unable to override toggle settings.

3 participants