Skip to content

ci: ♻️ skip Docker publish CI for forked PRs#179

Open
clins1994 wants to merge 1 commit into
beeper:mainfrom
clins1994:caio/fork-pr-docker-ci
Open

ci: ♻️ skip Docker publish CI for forked PRs#179
clins1994 wants to merge 1 commit into
beeper:mainfrom
clins1994:caio/fork-pr-docker-ci

Conversation

@clins1994

Copy link
Copy Markdown
Contributor

Summary

  • Skip the Docker publish job outside the upstream beeper/line repo
  • Avoid registry login/push on forked pull requests where GitHub does not expose registry secrets

Fixes #178

Testing

  • pre-commit run check-yaml --files .github/workflows/deploy.yml
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Added a conditional guard to the build-docker CI job that prevents execution on forked pull requests where Beeper registry secrets are unavailable, preventing login failures during Docker image pushes.

Changes

CI Registry Access Guard

Layer / File(s) Summary
Docker build job conditional guard
.github/workflows/deploy.yml
The build-docker job now includes an if: condition that gates execution to the main repository and contexts where private registry secrets are accessible, skipping the job on forked PRs to prevent login failures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly relates to the changeset, explaining why the Docker publish job is being skipped and referencing the linked issue.
Linked Issues check ✅ Passed The PR directly addresses issue #178 by adding a conditional to prevent Docker registry login/push on forked PRs where secrets are unavailable.
Out of Scope Changes check ✅ Passed All changes in the PR are scoped to the stated objective: adding an if-guard to the build-docker job to skip execution for forked PRs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the main change: adding a conditional guard to skip the Docker publish CI job for forked PRs, which matches the changeset's modification to the build-docker job condition.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@clins1994 clins1994 changed the title Skip Docker publish CI for forked PRs ci: ♻️ skip Docker publish CI for forked PRs Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

bug: 🐛 Docker CI fails on forked PRs without registry secrets

1 participant