Fix: Draw Gizmos in the same frame they are created (by moving update_gizmo_meshes to run in PostUpdate)#22802
Open
kfc35 wants to merge 2 commits intobevyengine:mainfrom
Open
Fix: Draw Gizmos in the same frame they are created (by moving update_gizmo_meshes to run in PostUpdate)#22802kfc35 wants to merge 2 commits intobevyengine:mainfrom
update_gizmo_meshes to run in PostUpdate)#22802kfc35 wants to merge 2 commits intobevyengine:mainfrom
Conversation
kfc35
added
A-Gizmos
kfc35
force-pushed
the
22438_gizmo_single_frame_render
branch
from
b178305 to
f4a89ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Assets<GizmoAsset>in theLastschedule, which executes afterAssetEventSystemsinPostUpdate. This causes their extraction to be delayed one frame, which means they don’t get rendered. You can read my investigation notes in the issue for a detailed look.AssetEventSystemsinPostUpdate. This ensures that messages of any new assets is received by the extractor and therefore rendered in the same frame.Testing
The reproduction code in #22438 now works as desired. After removing the gizmo that gets drawn every frame (by pressing d), pressing A or S for either of the single frame gizmo correctly renders them.