Open
Conversation
levydsa
force-pushed
the
reuse_view_key_cache
branch
from
6f334eb to
938ac5e
Compare
alice-i-cecile
added
C-Docs
github-project-automation
bot
moved this to Needs SME Triage
in Rendering (2026 Proposal)
atlv24
approved these changes
Feb 5, 2026
Contributor
atlv24
left a comment
atlv24
left a comment
There was a problem hiding this comment.
very nice cleanup. my only concern was maybe system ordering related regarding cache not being up to date for a frame when a view changes but i spot checked a few and the ordering looks right.
| } | ||
|
|
||
| /// This resource caches [`MeshPipelineKey`]s for each view with pre-enabled features needed to properly | ||
| /// setup the [`MeshViewBindGroup`] layout in specialized [`MeshPipeline`]s. |
Contributor
There was a problem hiding this comment.
note that bevy_sprite_render has a ViewKeyCache also, may be worth giving it a similar doc
tychedelia
approved these changes
Feb 5, 2026
kristoff3r
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
MeshPipelineKeyis tricky and can lead to easily avoidable errors: Atmosphere with Gizmos is broken #21784MeshPipelineViewLayoutKeypart ofMeshPipelineKeyfor each view inViewKeyCachewith the correct layout for any draw call that usesSetMeshViewBindGroupViewKeyCacheto properly setup the pipeline for any view features.Solution
ViewKeyCachewhere possible in the engine and examples.ViewKeyCache