Open
Conversation
…opagate_parent_transforms`. This has the added benefit of no longer dealing with random systems being picked up by the par_iter.
hymm
reviewed
Mar 27, 2026
| let nodes = &nodes; | ||
| let static_optimizations = &*static_optimizations; | ||
|
|
||
| task_pool.scope(|s| { |
Contributor
There was a problem hiding this comment.
how is this change preventing the scope from running systems?
Member
Author
There was a problem hiding this comment.
It never yields to the pool in this case. It will eagerly spawn workers and drive them to completion without ever giving it a chance to try to await system futures.
Anecdotally, using the buffered channel stuff elsewhere - which does await regularly - I haven't seen the system scheduling bug. I don't know if that's because there is always more work to do within the scope or something, but in practice it has been avoiding the systems-pulled-into-scopes stalls you see in traces.
IceSentry
added
C-Performance
Member
Author
|
FYI this needs more benchmarking before considering for merge. Edit: working through some degenerate cases found in bevy_city. |
alice-i-cecile
added
S-Needs-Benchmarking
…k the seeding worker does to offload it to the already optimized propagation workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing