Calculate UVs and Normals in ConvexPolygonMeshBuilder#23540
Open
mpowell90 wants to merge 5 commits intobevyengine:mainfrom
Open
Calculate UVs and Normals in ConvexPolygonMeshBuilder#23540mpowell90 wants to merge 5 commits intobevyengine:mainfrom
mpowell90 wants to merge 5 commits intobevyengine:mainfrom
Conversation
…stinguish the different shape
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
mpowell90
changed the title
mpowell90
changed the title
kfc35
added
C-Bug
kfc35
added
the
D-Straightforward
kfc35
approved these changes
Mar 28, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
Logic looks good to me. I checked out the branch and the extrusion looks OK to me too. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #23526
Solution
ConvexPolygonMeshBuilderTesting
test_convex_polygonto bevy_mesh which imitates a different test but for regular polygons.Extrusion<ConvexPolygon>to the 3d_shapes example - you can use this example to validate UVs and Normals are working as expected.