Repository navigation
search: a non-UTF-8 .git file is a per-path error (D2) - #594
Closed
jaredLunde wants to merge 32 commits into
Closed
jaredLunde wants to merge 32 commits into
jaredLunde wants to merge 32 commits into
Conversation
Hegel generates operation sequences (files, search, exec, and changes made behind the client's back); each runs in lockstep through every registered driver on its own root, and the answers are compared with each other and, on local backends, with std::fs. Findings D1..D5 are scenarios in differential-found.json, xfail for the clients that fail them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…lit at CR, VT, FF, U+2028) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d2-search-bad-git
… even on SIGKILL; differential tests run only in the clients job Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…, not a rejected pattern Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
… jared/fix-d2-search-bad-git
… jared/fix-d1-py-stderr-line
…o jared/fix-d2-search-bad-git
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d2-search-bad-git
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d2-search-bad-git # Conflicts: # sdk/conformance/FILES-OVER-EXEC.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…ferential tolerance Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 27, 2026
… jared/fix-d2-search-bad-git # Conflicts: # crates/sandbox-conformance/ARCHITECTURE.md
… built on the Rust client) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…rop exec.exact from the comparison Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…er lead out of the root Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…ad-git # Conflicts: # sdk/conformance/FILES-OVER-EXEC.md
… jared/fix-d2-search-bad-git # Conflicts: # crates/sandbox-conformance/ARCHITECTURE.md # sdk/conformance/scenarios/differential-found.json
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…ad-git # Conflicts: # crates/sandbox-conformance/ARCHITECTURE.md # crates/sandbox-conformance/tests/differential/oracle.rs # sdk/conformance/scenarios/differential-found.json
jaredLunde
enabled auto-merge
October 27, 2026 20:47
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 27, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes D2. rg reads the nearest
.gitas a gitdir pointer and, when it is not text, printsrg: PATH: stream did not contain valid UTF-8and exits 2 although the pattern is fine and the matches were printed.Decision: no rg flag fixes it.
--no-ignore-vcsand--no-ignoresilence it but drop the.gitignorehandling the helpers promise;--no-ignore-parentdoes not help;--no-require-gitis already conditional on the git probe and changes which ancestor ignore files apply. So the parsing changes: a stderr line ending instream did not contain valid UTF-8is a per-path error alongside the OS messages (Rust, TS, Python sync/async). Regex, glob and size-limit failures (rg: regex parse error:,rg: error parsing glob,rg: compiled regex exceeds size limit) stay invalid_query because every stderr line must be a per-path error. Spec (Exit codes and errors) states the rule. Removes both xfail marks and the D2 tolerance. No sandbox-mcp crate on main.Stacked on #592 (which carries #590); retarget once they land.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64