Skip to content

Android: more meaningful errors for non-200 HTTP responses #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofalvai merged 1 commit into from
Sep 3, 2026
+23 −0
Merged

Android: more meaningful errors for non-200 HTTP responses #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions android/app/src/main/java/com/microsoft/codepush/react/CodePushUpdateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,13 @@ public void downloadPackage(JSONObject updatePackage, String expectedBundleFileN
}

connection.setRequestProperty("Accept-Encoding", "identity");

int responseCode = connection.getResponseCode();
if (responseCode < 200 || responseCode >= 300) {
throw new CodePushUnknownException("Error downloading update package. Response code: "
+ responseCode + ". Response body: " + NetworkUtils.readStreamToString(connection.getErrorStream()));
}

bin = new BufferedInputStream(connection.getInputStream());

long totalBytes = connection.getContentLength();
Expand Down Expand Up @@ -349,6 +356,13 @@ public void downloadAndReplaceCurrentBundle(String remoteBundleUrl, String bundl
try {
downloadUrl = new URL(remoteBundleUrl);
connection = (HttpURLConnection) (downloadUrl.openConnection());

int responseCode = connection.getResponseCode();
if (responseCode < 200 || responseCode >= 300) {
throw new CodePushUnknownException("Error downloading update package. Response code: "
+ responseCode + ". Response body: " + NetworkUtils.readStreamToString(connection.getErrorStream()));
}

bin = new BufferedInputStream(connection.getInputStream());
File downloadFile = new File(getCurrentPackageBundlePath(bundleFileName));
downloadFile.delete();
Expand Down
9 changes: 9 additions & 0 deletions android/app/src/main/java/com/microsoft/codepush/react/NetworkUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
@file:JvmName("NetworkUtils")

package com.microsoft.codepush.react

import java.io.InputStream

fun readStreamToString(inputStream: InputStream?): String {
return inputStream?.bufferedReader()?.use { it.readText() } ?: ""

@ofalvai ofalvai Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why create a separate file for this one-liner? This comes from the Kotlin stdlib, so we can't do this same trick in CodePushUpdateManager.java. And because Android Java is stuck on Java 8 APIs, we would need to reimplement this in ~50 lines of Java.

}