Skip to content

feat(chunker): expand built-in artifact pattern list (#482) #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justn-hyeok merged 1 commit into from
Apr 20, 2026
Merged

feat(chunker): expand built-in artifact pattern list (#482) #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 74 additions & 5 deletions packages/core/src/pipeline/chunker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,27 +255,96 @@ export function chunkDiffFiles(
// ============================================================================

/**
* Default patterns for files that should never be reviewed.
* These are build outputs, lock files, and minified bundles — not source code.
* Users can add additional patterns via .reviewignore.
* Default patterns for files that should never be reviewed (#482).
* Build outputs, lock files, generated code, binary assets, and test
* snapshots — not source code. Users can add project-specific additions
* via `.reviewignore`.
*/
export const BUILT_IN_ARTIFACT_PATTERNS = [
// Build outputs — directory-level
'dist/**',
'build/**',
'out/**',
'.next/**',
'.nuxt/**',
'.svelte-kit/**',
'.turbo/**',
'.docusaurus/**',
'storybook-static/**',
'coverage/**',
'node_modules/**',

// Minified / bundled
'**/*.min.js',
'**/*.min.css',
'**/*.min.mjs',
'**/*.bundle.js',
'**/*.bundle.css',
'**/*.bundle.mjs',

// Source maps
'**/*.js.map',
'**/*.mjs.map',
'**/*.css.map',
'**/*.d.ts.map',

// Generated code (by convention)
'**/*.pb.go',
'**/*.pb.ts',
'**/*.pb.py',
'**/*_pb.js',
'**/*_pb.ts',
'**/*.gen.ts',
'**/*.gen.go',
'**/*_generated.go',
'**/*_generated.ts',

// Lock files — JS ecosystem
'pnpm-lock.yaml',
'package-lock.json',
'yarn.lock',
'bun.lockb',
'**/*.d.ts.map',
'**/*.js.map',
'bun.lock',
// Lock files — other ecosystems
'Cargo.lock',
'poetry.lock',
'Pipfile.lock',
'uv.lock',
'composer.lock',
'Gemfile.lock',
'go.sum',
'mix.lock',
'flake.lock',

// Binary assets
'**/*.png',
'**/*.jpg',
'**/*.jpeg',
'**/*.gif',
'**/*.webp',
'**/*.ico',
'**/*.bmp',
'**/*.tiff',
'**/*.woff',
'**/*.woff2',
'**/*.ttf',
'**/*.otf',
'**/*.eot',
'**/*.mp3',
'**/*.mp4',
'**/*.mov',
'**/*.webm',
'**/*.pdf',
'**/*.zip',
'**/*.tar',
'**/*.gz',
'**/*.tgz',
'**/*.7z',
'**/*.rar',

// Test snapshots
'**/*.snap',
'**/__snapshots__/**',
];

// ============================================================================
Expand Down
99 changes: 99 additions & 0 deletions packages/core/src/tests/pipeline-chunker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
loadReviewIgnorePatterns,
chunkDiff,
REVIEW_IGNORE_MAX_BYTES,
BUILT_IN_ARTIFACT_PATTERNS,
} from '../pipeline/chunker.js';

// ============================================================================
Expand Down Expand Up @@ -161,6 +162,104 @@ describe('filterIgnoredFiles', () => {
});
});

// ============================================================================
// BUILT_IN_ARTIFACT_PATTERNS (#482)
// ============================================================================

describe('BUILT_IN_ARTIFACT_PATTERNS', () => {
// Each entry is a filePath that MUST be filtered out by the built-in
// pattern list. Failure of any of these is a regression in the default
// exclusion set.
const SHOULD_BE_FILTERED: string[] = [
// Build outputs
'dist/bundle.js',
'build/index.html',
'out/chunk.abc.js',
'.next/server/pages/index.js',
'.nuxt/client.js',
'.svelte-kit/output/client/app.js',
'.turbo/cache/abc.log',
'.docusaurus/registry.js',
'storybook-static/iframe.html',
'coverage/lcov.info',
'node_modules/react/index.js',
// Minified / bundled
'assets/vendor.min.js',
'assets/styles.min.css',
'assets/app.bundle.js',
'assets/app.bundle.mjs',
// Source maps
'src/app.js.map',
'src/app.css.map',
'src/types.d.ts.map',
// Generated code
'proto/messages.pb.go',
'proto/messages.pb.ts',
'proto/messages.pb.py',
'gen/service_pb.js',
'gen/service.gen.ts',
'gen/handlers_generated.go',
// Lock files (JS ecosystem)
'pnpm-lock.yaml',
'package-lock.json',
'yarn.lock',
'bun.lockb',
'bun.lock',
// Lock files (other ecosystems)
'Cargo.lock',
'poetry.lock',
'Pipfile.lock',
'uv.lock',
'composer.lock',
'Gemfile.lock',
'go.sum',
'mix.lock',
'flake.lock',
// Binary assets
'assets/logo.png',
'assets/hero.jpg',
'assets/icon.svg.ignored-ext-so-skip', // placeholder to keep list intact
'docs/diagram.webp',
'public/favicon.ico',
'assets/font.woff2',
'assets/font.ttf',
'assets/demo.mp4',
'docs/spec.pdf',
'releases/build.zip',
'releases/build.tar.gz',
// Test snapshots
'src/__snapshots__/foo.test.ts.snap',
'components/__snapshots__/Button.test.tsx.snap',
'src/foo.snap',
].filter((p) => !p.endsWith('.ignored-ext-so-skip'));

// Files that MUST survive the built-in filter — real source code that
// shares prefixes with filtered directories.
const SHOULD_SURVIVE: string[] = [
'src/foo.ts',
'packages/core/src/pipeline/chunker.ts',
'distribution/index.ts', // starts with "dist" but not dist/
'src/build-helpers.ts', // has "build" in the name, not a dir
'src/node_modules_adapter.ts', // substring match false positive guard
'scripts/postinstall.cjs',
'tests/fixtures/sample.snapshot.json', // .snapshot, not .snap
];

for (const p of SHOULD_BE_FILTERED) {
it(`filters ${p}`, () => {
const result = filterIgnoredFiles([{ filePath: p }], BUILT_IN_ARTIFACT_PATTERNS);
expect(result).toHaveLength(0);
});
}

for (const p of SHOULD_SURVIVE) {
it(`keeps source-code path ${p}`, () => {
const result = filterIgnoredFiles([{ filePath: p }], BUILT_IN_ARTIFACT_PATTERNS);
expect(result).toHaveLength(1);
});
}
});

// ============================================================================
// loadReviewIgnorePatterns
// ============================================================================
Expand Down
Loading