feat(chunker): expand built-in artifact pattern list (#482)#498
Merged
justn-hyeok merged 1 commit intomainfrom Apr 20, 2026
Merged
feat(chunker): expand built-in artifact pattern list (#482)#498justn-hyeok merged 1 commit intomainfrom
justn-hyeok merged 1 commit intomainfrom
Conversation
Before this change, BUILT_IN_ARTIFACT_PATTERNS covered the common JS
ecosystem basics (dist/, node_modules/, minified JS/CSS, JS lock files)
but missed several generated-code patterns that still reach reviewers
in real repos — burning cost and triggering phantom findings on code
that no human wrote.
Added categories:
- Build outputs: .svelte-kit/, .turbo/, .docusaurus/, storybook-static/
- Minified / bundled: *.min.mjs, *.bundle.{css,mjs}
- Source maps: *.mjs.map, *.css.map
- Generated code: *.pb.{go,ts,py}, *_pb.{js,ts}, *.gen.{ts,go},
*_generated.{go,ts}
- Lock files (other ecosystems): Cargo.lock, poetry.lock,
Pipfile.lock, uv.lock, composer.lock, Gemfile.lock, go.sum,
mix.lock, flake.lock, bun.lock
- Binary assets: png/jpg/jpeg/gif/webp/ico/bmp/tiff, woff/woff2/ttf/
otf/eot, mp3/mp4/mov/webm, pdf, zip/tar/gz/tgz/7z/rar
- Test snapshots: *.snap, __snapshots__/
Added 51 test cases covering each new filtered path plus 7 "should
survive" cases to guard against prefix/substring false matches (e.g.
distribution/index.ts is NOT dist/, src/build-helpers.ts is NOT
build/). Tests 3368 → 3426.
Config `ignorePatterns` override and the `.reviewignore` syntax are
both already supported (chunker.loadReviewIgnorePatterns) — users who
want additional patterns for their specific project add them there.
The full "zero-config for N ecosystems" acceptance criterion in #482
stays open; this PR delivers the concrete default-list expansion.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ CodeAgora: ACCEPT
no issues | 5 reviewers
There were no discussions, no escalations, and no reported findings at any severity level, so there is no evidence of a blocking defect or unresolved ambiguity. Based on the available review data, the change appears safe to merge.
CodeAgora · Session: 2026-04-20/001
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand `BUILT_IN_ARTIFACT_PATTERNS` with the generated-code / build-output / lock-file / binary patterns the default list was missing.
Added categories
Scope
Only the default list was expanded. The two escape hatches that already existed are unchanged:
The full "zero-config across every ecosystem" acceptance criterion in #482 stays open; this PR is the concrete default-list improvement.
Test plan
Risks