Repository navigation
chore: align analysis and record architecture decisions - #113
Merged
leoafarias merged 5 commits intoSep 21, 2026
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit d3cbb8d): https://superdeck-dev--pr113-chore-analysis-parit-yckd68bo.web.app (expires Wed, 21 Oct 2026 20:49:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bd68fc230762285849207e7e120aaf87cd4ca2f9 |
leoafarias
added this pull request to stack #119
September 21, 2026 20:28
leoafarias
force-pushed
the
chore/analysis-parity-and-decisions
branch
from
September 21, 2026 20:32
bd1bc0b to
7800a53
Compare
The workflow ran the Dart analyzer with `fatal-infos: false` and `fatal-warnings: false`, before `pub get` and before code generation, so a green run said less than `melos run analyze` does. It now runs `melos run analyze:dart --no-select` after the build runner, which is exactly the first half of the local command. Records the two gaps this cannot close from here: DCM needs a runner binary and a licence secret, and the playground's DCM baseline hides 630 findings. Both are measured and written down, with the order to tackle them and a warning about `dcm fix`, which on this tree rewrote dependency-injection call sites and broke one file.
The CLI build and the editor's preview codec held the same four calls in the same order: split the Markdown, parse front matter into options, and parse sections and comments. `assembleSlides` is now that function, and both call it. Plugins stay a build concern and the editor's `DeckFormatException` stays an editor concern. Consolidating only after parity was proven is what the first-principles report asked for; the evidence, and the method for the renderer question it also left open, are written down in docs/maintainers/renderer-and-assembly-evaluation.md, along with the work the editor's removal retired.
Removing the editor left 187 suppressed findings across 21 files that no longer exist, a third of the baseline. A stale entry cannot hide a current finding, so deleting them changes no analysis result — `dcm analyze` is still clean — and it stops the file from overstating the debt. 468 suppressed findings remain, all naming live files.
States for each finding whether it still applies and where it was fixed, or that the editor's removal retired it and what replaced it, using the report's own labels. Adds the §6 hardening answers, the measured Mermaid web bundle delta in the ADR, and the two checks this environment cannot run: no macOS app builds at all against the repo's 10.15 deployment target on this Xcode, and Playwright's WebKit build does not install on macOS 27. Raising the deployment target is left as an isolated decision.
leoafarias
force-pushed
the
chore/analysis-parity-and-decisions
branch
from
September 21, 2026 20:38
7800a53 to
609cb1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
feat/superdeck-mermaid-core; review only the commits in this PR boundary.Validation
fvm dart run melos run build_runner:build --no-select— passed with no generated difffvm dart run melos run contracts:check --no-select— passedfvm dart run melos run analyze --no-select— passedfvm dart run melos run test --no-select— passed across 2,142 tests