fix bug for file paths in windows during componentization#213
Merged
tschneidereit merged 5 commits intobytecodealliance:mainfrom Apr 2, 2025
Merged
fix bug for file paths in windows during componentization#213tschneidereit merged 5 commits intobytecodealliance:mainfrom
tschneidereit merged 5 commits intobytecodealliance:mainfrom
Conversation
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
The npm tests depend on environment variables and `cross-env` helps us perform it easily.env Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
fix_windows_builds
branch
from
de4358d to
dbda420
Compare
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
tschneidereit
approved these changes
Apr 2, 2025
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Thank you for doing this! I left one request inline, but I hope that's easy to satisfy.
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug with the file paths not being passed through
maybeWindowsPathfor the initializer and the source directories.fixes #212