Skip to content

ci: add caching for rust jobs #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkatychev merged 5 commits into from
Jul 3, 2026
+16 −6
Merged

ci: add caching for rust jobs #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
766959a
ci: add caching for rust jobs
mkatychev Jul 2, 2026
bb069de
fix: add p1 toolchain target
mkatychev Jul 2, 2026
b9825c6
test caching
mkatychev Jul 2, 2026
31ec6cd
revert(ci): add back safe-if on main flag
mkatychev Jul 2, 2026
7223202
fix(ci): bin action hashes
mkatychev Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,17 @@ jobs:
- os: macos-latest
docker_tests_flags: "--no-default-features"
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

# selecting a toolchain either by action or manual `rustup` happen
# before cache setup
- run: rustup toolchain install stable --profile minimal

- name: Set up rust cache
uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
with:
targets: "wasm32-wasip1"
save-if: ${{ github.ref == 'refs/heads/main' }}


- name: Run lints
if: matrix.run_lints
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-binaries.yml
View file
Open in desktop
Comment thread
mkatychev marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Install Rust
run: rustup update stable --no-self-update && rustup default stable && rustup target add ${{ matrix.rust-target }}
- run: cargo build --release --target ${{ matrix.rust-target }}
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Install Rust
run: rustup update stable --no-self-update && rustup default stable && rustup target add ${{ matrix.rust-target }}
- run: cargo build --release --target ${{ matrix.rust-target }}
Expand All @@ -129,7 +129,7 @@ jobs:
env:
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Install Rust
run: rustup update stable --no-self-update && rustup default stable
- name: Publish wasm-pkg-common
Expand Down
3 changes: 3 additions & 0 deletions rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[toolchain]
channel = "stable"
targets = ["wasm32-wasip1"]

@mkatychev mkatychev Jul 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump this to p2?

@vados-cosmonic vados-cosmonic Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add p2 alongside? IIRC when building P3 components we still build p1 first then adapt our way there, due to upstream toolchain mismatches

Loading