ci: add caching for rust jobs#222
Open
mkatychev wants to merge 5 commits into
Open
Conversation
mkatychev
commented
Jul 2, 2026
| @@ -0,0 +1,3 @@ | |||
| [toolchain] | |||
| channel = "stable" | |||
| targets = ["wasm32-wasip1"] | |||
Member
Author
There was a problem hiding this comment.
Should we bump this to p2?
Contributor
There was a problem hiding this comment.
Can we add p2 alongside? IIRC when building P3 components we still build p1 first then adapt our way there, due to upstream toolchain mismatches
mkatychev
commented
Jul 2, 2026
| @@ -0,0 +1,3 @@ | |||
| [toolchain] | |||
| channel = "stable" | |||
| targets = ["wasm32-wasip1"] | |||
Contributor
There was a problem hiding this comment.
Can we add p2 alongside? IIRC when building P3 components we still build p1 first then adapt our way there, due to upstream toolchain mismatches
Member
Author
|
Unless we explicitly call both p2 and p1 as targets, we should not gain any benefits here, rustup will just spend more time downloading. Perhaps orthogonalize the tests? |
Contributor
|
Yeah in this case then let's just leave it P1 and consider later! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
rust-toolchain.tomlas well