Convert subpackage-list to TypeScript - #8
Merged
Merged
Conversation
- index.js -> index.ts + types.ts (TransformArgs/TransformOptions, PackageManifest) - index.spec.js -> index.spec.ts, snapshot renamed to index.spec.ts.snap - example.js -> example.ts - packaging flip to dist/ output with declarations, prepack build hook - README example block and prose updated for the .ts rename - changeset: minor release for shipped type declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave-A TypeScript conversion per the phase-3 plan (engines pilot pattern): index.ts + per-package types.ts (exported TransformArgs/TransformOptions), spec + example converted (.ts specifiers, native Node ≥22.18 type-stripping for dev), dist packaging (exports/types → dist/, files: ["dist"], prepack build), changeset minor (types added, zero runtime change).
Logic byte-for-byte vs main (review-verified line-by-line).
Package-specific:
verbosetypedboolean | string— documents the pre-existing runtime contract (only the string 'true' enables verbose; a strict-mode surfacing, not a behavior change).Validation: typecheck + lint + prettier clean · full workspace tests green · tarball gate incl. consumer-typecheck (installed tarball, consumer .ts, tsc --strict --noEmit) · node example.ts exit 0 · docs idempotent · code-reviewed (APPROVE)