[Misc] Add enableCleanupMonitoring configuration support & serviceExposure restriction removal

[anirudhprasad-sap]

• Enhancement as per request from issue - serviceExposures Only Generated for Service-Only Charts #95 && Missing enable-cleanup-monitoring Annotation on CAPApplication #96
• Added ttlSecondsAfterFinished defaults to job workloads

[hyperspace-insights]

Summary

The following content is AI-generated and provides a summary of the pull request:

---

Add enableCleanupMonitoring Configuration & Remove serviceExposures Chart-Type Restriction

New Features

✨ This PR introduces two enhancements to the CAP Operator plugin:

1. enableCleanupMonitoring support: Adds the sme.sap.com/enable-cleanup-monitoring annotation to CAPApplication resources, defaulting to true. This allows the CAP Operator to automatically clean up stale CAPApplicationVersion resources that accumulate after Helm upgrades or ArgoCD syncs.

2. Unrestricted serviceExposures generation: Removes the service-only chart type guard on the serviceExposures block in the configurable templates chart. The block is already wrapped in a conditional ({{- if .Values.serviceExposures }}), so it has no effect when not configured — enabling multi-tenant apps with approuters to use direct ingress routes for BTP callbacks.

3. ttlSecondsAfterFinished: 300 is now set as a default on all job workloads (TenantOperation, Content, ams-deployer) to ensure finished Kubernetes jobs are cleaned up automatically.

Changes

• lib/util.js: Added sme.sap.com/enable-cleanup-monitoring annotation unconditionally (both IAS and non-IAS paths); removed isService guard on serviceExposures in configurable templates; added ttlSecondsAfterFinished: 300 default to all job workload definitions via a Helm merge.
• files/chart/values.yaml.hbs & files/configurableTemplatesChart/values.yaml.hbs: Added enableCleanupMonitoring: true default under the app section.
• files/chart/values.schema.json & files/configurableTemplatesChart/values.schema.json: Added enableCleanupMonitoring boolean field to the app schema definition.
• hack/schema-generation.go: Added EnableCleanupMonitoring field to the app struct for schema generation.
• test/files/expected*: Updated all expected chart templates and values files to reflect the new annotation, ttlSecondsAfterFinished, and unrestricted serviceExposures output.

Jira Issues

• #95: serviceExposures Only Generated for Service-Only Charts
• #96: Missing enable-cleanup-monitoring Annotation on CAPApplication

---

• 🔄 Regenerate and Update Summary
• ✏️ Insert as PR Description (deletes this comment)
• 🗑️ Delete comment

PR Bot Information

Version: 1.20.33

• Summary Prompt: Default Prompt
• GithubContextProvider: serviceExposures Only Generated for Service-Only Charts #95
• LLM: anthropic--claude-4.6-sonnet
• File Content Strategy: Full file content
• GithubContextProvider: Missing enable-cleanup-monitoring Annotation on CAPApplication #96
• Correlation ID: 7b99ff4e-9949-4667-96d1-b27f8425f408
• Event Trigger: issue_comment.edited
• Output Template: Default Template

[hyperspace-insights]

The PR adds enableCleanupMonitoring support across schemas, the Go struct, template generation logic, and test fixtures. The implementation is consistent and the logic is correct.

One minor gap worth noting: the new enableCleanupMonitoring boolean field is defined in both values.schema.json files and used in the generated Helm templates, but it is not added to either values.yaml.hbs template (files/chart/values.yaml.hbs and files/configurableTemplatesChart/values.yaml.hbs). As a result, users have no indication this opt-in field exists, and there is no explicit false default in the generated values.yaml. Every other app-level field has a commented entry in those templates. Consider adding # -- Enable cleanup monitoring for the CAP application / enableCleanupMonitoring: false under the app: section in both .hbs files to improve discoverability and self-documentation of the chart.

PR Bot Information

Version: 1.20.33

• LLM: anthropic--claude-4.6-sonnet
• Correlation ID: 49f5bc57-b60f-42a3-8257-ad58068c3247
• Event Trigger: pull_request.opened
• File Content Strategy: Full file content

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Pavan-SAP]

✅