Skip to content

docs: fix broken internal links - #34232

Merged
mvvmm merged 5 commits into
productionfrom
fix/internal-links
Oct 12, 2026
Merged

mvvmm merged 5 commits into
productionfrom
fix/internal-links

Conversation

@mvvmm

@mvvmm mvvmm commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes internal links that don't resolve, found by nimbus-docs lint. After this PR, a local build + lint reports 0 errors.

  • Adds 5 _redirects rules for email security pages that moved without redirects, and points links at the new URLs.
  • Rewrites 200 links that went through a redirect to point at the destination directly. The 9 with #anchors were checked against the destination page: 6 anchors kept, 2 retargeted to renamed headings, 1 retargeted to the dedicated page (PhishNet 365).
  • Fixes 17 broken links with an obvious target: renamed or lowercased paths, a missing leading /, changelog product pages.
  • Fixes the Access RDP GA changelog link to the open beta entry.
  • Removes links to pages that don't exist yet: /kv/reference/kv-instant/ and the CASB Zoom page (open PR [CASB] Adding Zoom Support #33761). Re-add them when those pages ship.
  • Removes the reference to the GitHubCode component, which no longer exists.
  • Disables nimbus/internal-link in the link-in-props example partial, which shows a bad link on purpose.

Documentation checklist

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-internal-links.previews.developers.cloudflare.com (commit e8f97e5)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://4b36feb8.previews.developers.cloudflare.com e8f97e5 2026-10-12T19:19:23.267Z Visit the dashboard ↗
  • Build: In progress 🔵

View logs ↗
08b74b3 2026-10-12T19:11:01.913Z View logs ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://47606b12.previews.developers.cloudflare.com eb6b211 2026-10-12T19:08:15.489Z Visit the dashboard ↗
  • Build: In progress 🔵

View logs ↗
631075d 2026-10-12T18:46:27.555Z View logs ↗

@github-actions github-actions Bot added size/m product:workers Related to Workers product product:terraform Related to Terraform product product:analytics Related to Analytics product product:bots Related to Bots product product:logs Related to Logs product:ssl Related to SSL product:cache Issues or PRs related to Cache product:waf product:reference-architecture product:cloudflare-for-platforms product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ product:fundamentals and removed size/m labels Oct 12, 2026
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

AI Review

✅ Reviewed e8f97e5 · 15 findings · incremental

👉 Fix in your agent 👈
Fix the following review findings in PR #34232 (https://github.com/cloudflare/cloudflare-docs/pull/34232).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification.
- If you disagree, explain why.
- If you need clarification before deciding, ask those questions.
- Then share your plan for which issues to tackle and in what order.

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit because the next review reads PR comments.

## Style Guide
- S-03dae109 | src/content/changelog/access/2025-09-22-browser-based-rdp-ga.mdx:11 | Contraction in prose
  The added line contains the contraction `we've`. Prose must not contain contractions (exception only inside code blocks or backtick spans).
- S-0bbacbaa | src/content/changelog/agents/2025-03-18-npm-i-agents.mdx:112 | Contraction in prose
  The added line contains the contraction `We've`. Prose must not contain contractions.
- S-051154bf | src/content/changelog/terraform/2025-05-06-terraform-v5.4.0-provider.mdx:9 | Unnecessary `please` in prose
  The added line contains `Please`, which the writing style rules say to remove from prose.
- S-01c7d2ac | src/content/changelog/terraform/2025-05-19-terraform-v5.5.0-provider.mdx:9 | Unnecessary `please` in prose
  The added line contains `Please`, which the writing style rules say to remove from prose.
- S-0fd6bede | src/content/changelog/terraform/2025-07-11-terraform-v5.7.0-provider.mdx:9 | Contraction in prose
  The added line contains the contraction `it's`. Prose must not contain contractions.
- S-1ed4e874 | src/content/changelog/workers/2025-04-08-deploy-to-cloudflare-button.mdx:17 | Contraction in prose
  The added line contains the contraction `you'd`. Prose must not contain contractions.
- S-002d95fa | src/content/changelog/workers/2025-08-08-support-long-branch-names-preview-aliases.mdx:9 | Contraction in prose
  The added line contains the contraction `We've`. Prose must not contain contractions.
- S-1eaa4e71 | src/content/changelog/workers/2025-09-07-builds-increased-cpu-paid.mdx:7 | Contraction in prose
  The added line contains the contraction `we're`. Prose must not contain contractions.
- S-004e7ac8 | src/content/changelog/workers/2025-09-16-remote-bindings-ga.mdx:11 | Contractions in prose
  The added line contains the contractions `we're` and `it's`. Prose must not contain contractions.
- S-02ef0d84 | src/content/changelog/workers/2025-09-17-update-preview-url-setting.mdx:8 | Contraction in prose
  The added line contains the contraction `we've`. Prose must not contain contractions.
- S-18ef5519 | src/content/changelog/workers/2025-10-23-preview-url-default-behavior.mdx:26 | Contraction in prose
  The added line contains the contraction `didn't`. Prose must not contain contractions.
- S-0dfb5a49 | src/content/changelog/containers/2026-02-17-docker-in-docker.mdx:18 | `see the [link]` phrasing
  The added line uses `see the [Docker-in-Docker guide]` and `see the [Containers FAQ]`; prose should use `refer to [link]` instead of `see the [link]`.
- S-154554f4 | src/content/docs/cloudflare-one/email-security/index.mdx:33 | Missing serial comma
  The list `allow policies, blocked senders, trusted domains, impersonation registry and additional detections` has five items joined by `and` with no comma before the final conjunction.
- S-098f4b36 | src/content/docs/cloudflare-one/email-security/monitoring/index.mdx:112 | Missing serial comma
  The list `allowed traffic, blocked traffic and domain age` has three items joined by `and` with no comma before the final conjunction.
- S-0a4d6e0c | src/content/partials/durable-objects/do-sqlite-storage-no-bill-note.mdx:6 | Time-sensitive month and year in prose
  The added line contains `January 2026` and `January 7, 2026`. Outside `src/content/changelog/`, prose must not reference month names or four-digit years.

Style Guide

  • src/content/changelog/access/2025-09-22-browser-based-rdp-ga.mdx:11 · Contraction in prose

    The added line contains the contraction we've. Prose must not contain contractions (exception only inside code blocks or backtick spans).

  • src/content/changelog/agents/2025-03-18-npm-i-agents.mdx:112 · Contraction in prose

    The added line contains the contraction We've. Prose must not contain contractions.

  • src/content/changelog/terraform/2025-05-06-terraform-v5.4.0-provider.mdx:9 · Unnecessary please in prose

    The added line contains Please, which the writing style rules say to remove from prose.

  • src/content/changelog/terraform/2025-05-19-terraform-v5.5.0-provider.mdx:9 · Unnecessary please in prose

    The added line contains Please, which the writing style rules say to remove from prose.

  • src/content/changelog/terraform/2025-07-11-terraform-v5.7.0-provider.mdx:9 · Contraction in prose

    The added line contains the contraction it's. Prose must not contain contractions.

  • src/content/changelog/workers/2025-04-08-deploy-to-cloudflare-button.mdx:17 · Contraction in prose

    The added line contains the contraction you'd. Prose must not contain contractions.

  • src/content/changelog/workers/2025-08-08-support-long-branch-names-preview-aliases.mdx:9 · Contraction in prose

    The added line contains the contraction We've. Prose must not contain contractions.

  • src/content/changelog/workers/2025-09-07-builds-increased-cpu-paid.mdx:7 · Contraction in prose

    The added line contains the contraction we're. Prose must not contain contractions.

  • src/content/changelog/workers/2025-09-16-remote-bindings-ga.mdx:11 · Contractions in prose

    The added line contains the contractions we're and it's. Prose must not contain contractions.

  • src/content/changelog/workers/2025-09-17-update-preview-url-setting.mdx:8 · Contraction in prose

    The added line contains the contraction we've. Prose must not contain contractions.

  • src/content/changelog/workers/2025-10-23-preview-url-default-behavior.mdx:26 · Contraction in prose

    The added line contains the contraction didn't. Prose must not contain contractions.

  • src/content/changelog/containers/2026-02-17-docker-in-docker.mdx:18 · see the [link] phrasing

    The added line uses see the [Docker-in-Docker guide] and see the [Containers FAQ]; prose should use refer to [link] instead of see the [link].

  • src/content/docs/cloudflare-one/email-security/index.mdx:33 · Missing serial comma

    The list allow policies, blocked senders, trusted domains, impersonation registry and additional detections has five items joined by and with no comma before the final conjunction.

  • src/content/docs/cloudflare-one/email-security/monitoring/index.mdx:112 · Missing serial comma

    The list allowed traffic, blocked traffic and domain age has three items joined by and with no comma before the final conjunction.

  • src/content/partials/durable-objects/do-sqlite-storage-no-bill-note.mdx:6 · Time-sensitive month and year in prose

    The added line contains January 2026 and January 7, 2026. Outside src/content/changelog/, prose must not reference month names or four-digit years.

Commands
  • /review Run a review now.
  • /full-review Review the entire PR diff.
  • /disable-auto-review Stop automatic reviews.
  • /rebase Rebase against production.

@github-actions

Copy link
Copy Markdown
Contributor

Preview URL: https://e8f97e5b.preview.developers.cloudflare.com
Preview Branch URL: https://fix-internal-links.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/changelog/post/2026-06-09-deprecating-sandbox-sdk-features/ https://fix-internal-links.preview.developers.cloudflare.com/changelog/post/2026-06-09-deprecating-sandbox-sdk-features/
https://developers.cloudflare.com/cloudflare-one/email-security/monitoring/ https://fix-internal-links.preview.developers.cloudflare.com/cloudflare-one/email-security/monitoring/
https://developers.cloudflare.com/email-security/migrate-to-email-security/ https://fix-internal-links.preview.developers.cloudflare.com/email-security/migrate-to-email-security/
https://developers.cloudflare.com/changelog/post/2025-10-23-preview-url-default-behavior/ https://fix-internal-links.preview.developers.cloudflare.com/changelog/post/2025-10-23-preview-url-default-behavior/
https://developers.cloudflare.com/cloudflare-one/email-security/phishguard/ https://fix-internal-links.preview.developers.cloudflare.com/cloudflare-one/email-security/phishguard/
https://developers.cloudflare.com/cloudflare-one/email-security/setup/ https://fix-internal-links.preview.developers.cloudflare.com/cloudflare-one/email-security/setup/
https://developers.cloudflare.com/fundamentals/api/reference/permissions/ https://fix-internal-links.preview.developers.cloudflare.com/fundamentals/api/reference/permissions/
https://developers.cloudflare.com/learning-paths/cybersafe/email-security-onboarding/email-security-next-steps/ https://fix-internal-links.preview.developers.cloudflare.com/learning-paths/cybersafe/email-security-onboarding/email-security-next-steps/
https://developers.cloudflare.com/reference-architecture/architectures/email-security-deployments/ https://fix-internal-links.preview.developers.cloudflare.com/reference-architecture/architectures/email-security-deployments/
https://developers.cloudflare.com/cloudflare-one/access-controls/ai-controls/mcp-portals/ https://fix-internal-links.preview.developers.cloudflare.com/cloudflare-one/access-controls/ai-controls/mcp-portals/
https://developers.cloudflare.com/cloudflare-one/email-security/settings/detection-settings/best-practices/ https://fix-internal-links.preview.developers.cloudflare.com/cloudflare-one/email-security/settings/detection-settings/best-practices/
https://developers.cloudflare.com/learning-paths/secure-your-email/configure-email-security/active-directory-sync/ https://fix-internal-links.preview.developers.cloudflare.com/learning-paths/secure-your-email/configure-email-security/active-directory-sync/
https://developers.cloudflare.com/changelog/post/2026-02-20-codemode-sdk-rewrite/ https://fix-internal-links.preview.developers.cloudflare.com/changelog/post/2026-02-20-codemode-sdk-rewrite/
https://developers.cloudflare.com/changelog/post/2026-02-23-sandbox-backup-restore-api/ https://fix-internal-links.preview.developers.cloudflare.com/changelog/post/2026-02-23-sandbox-backup-restore-api/
https://developers.cloudflare.com/changelog/post/2026-09-09-casb-zoom-integration/ https://fix-internal-links.preview.developers.cloudflare.com/changelog/post/2026-09-09-casb-zoom-integration/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants