Repository navigation
Pass through unmodeled top-level stemcell.MF keys - #65
Merged
Merged
Conversation
selzoc
marked this pull request as draft
October 9, 2026 04:24
This was referenced Oct 9, 2026
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
Alphasite
reviewed
Oct 9, 2026
Alphasite
reviewed
Oct 9, 2026
selzoc
marked this pull request as ready for review
October 9, 2026 20:15
selzoc
commented
Oct 9, 2026
selzoc
force-pushed
the
preserve-unknown-manifest-fields
branch
from
October 9, 2026 20:21
60119b4 to
6686d96
Compare
The light stemcell builder reads stemcell.MF into a fixed struct and writes it back, so any top-level key the struct does not model is silently dropped. Stemcells now advertise agent_features, which bosh-cli reads to decide whether to put a hashed agent mbus password in VM metadata. Dropping that key leaves light-stemcell Directors with a plaintext password. Keep unmodeled top-level keys in an inline map so they survive the rewrite. cloud_properties is still rebuilt from scratch, because the builder deliberately replaces it with the AMI mapping. ai-assisted=yes TNZ-129825 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
selzoc
force-pushed
the
preserve-unknown-manifest-fields
branch
from
October 9, 2026 20:23
6686d96 to
9c24d94
Compare
Alphasite
approved these changes
Oct 9, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The light builder reads
stemcell.MFinto a fixed struct and writes it back, so it silently drops any top-level key it doesn't model. Stemcells now advertiseagent_features(cloudfoundry/bosh-linux-stemcell-builder#761), and bosh-cli reads it to decide whether to put a hashed agent mbus password in VM metadata (cloudfoundry/bosh-cli#742). If the key is dropped, Directors on AWS light stemcells keep a plaintext password in user data.What
Extra map[string]interface{}withyaml:",inline"tomanifest.Manifest. Top-level keys the struct doesn't model, now and in the future, survive the rewrite.cloud_propertiesis still rebuilt from scratch asinfrastructure+ami, as before.Release ordering
Release this before the first stemcell that lists
http-password-hmac-sha256. If it ships later, AWS light stemcells just won't advertise the feature, which fails safe: the old plaintext behavior.Tests
New specs cover:
agent_featuresand an arbitrary unknown key survive a read/write round trip.agent_featuresisn't added when the input has none.Related
🤖 Generated with Claude Code