Repository navigation
chore(coverage): raise the unit coverage floor to 99/99/99/99 and fix the documented values - #500
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…the documented values main reaches 100 / 99.7 / 100 / 100 (lines / branches / functions / statements) while vitest.config.mjs gated build-test at 95 / 93 / 98 / 95, leaving ~120 lines of slack before a regression fails. Set the floor just under the current figure, the same rule as #202 and #484, and correct docs/contributing.md, which still listed the pre-#202 values 85/83/91/85. Closes #499 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
2 tasks
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
Contributor
|
Please add a kind label with |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Files claimed:
vitest.config.mjs(coverage.thresholds),docs/contributing.md(line 48). Test configuration and its documentation only — nosrc/,__tests__/ordist/change. Disjoint from #497 (src/plugins/approve.ts,src/issueComment/meow.ts) and #498 (__tests__/bundle/tideOptionalFields.test.ts).vitest.config.mjs:thresholds95 / 93 / 98 / 95 → 99 / 99 / 99 / 99 (lines / branches / functions / statements), with a comment recording the figure it was set under, the same wayvitest.e2e-coverage.config.mjsdoes. Same rule as chore(coverage): raise vitest coverage thresholds to the current floor #202 and chore(coverage): give the bundle e2e coverage run a regression floor (99/95/98/99) instead of zeroed thresholds #484: a floor just under whatmainreaches, so a drop of about one point failsbuild-testinstead of ~5 points.docs/contributing.md:48: thenpm run test:coveragerow listed the pre-chore(coverage): raise vitest coverage thresholds to the current floor #202 values 85 / 83 / 91 / 85; it now names the values invitest.config.mjs.Verification (local, this branch, main @ 1062ce7)
npx eslint vitest.config.mjscleannpm run test:coverage: 157 files / 2116 tests pass under the new thresholds; totals 100 % lines (2424/2424), 99.7 % branches (1662/1667), 100 % functions (500/500), 100 % statements (2546/2546)vitest.e2e-coverage.config.mjsresolves unchanged aftermergeConfig:{lines:99, branches:95, functions:98, statements:99}(main measures 99.95 / 97.96 / 100 / 99.96 at the same revision)approve.ts:415(refactor(approve, meow): drop the three dead arms left open on #466 #497 drops it) and the four negative-count arms from ast-v8-to-istanbul#207 already recorded on [quality] coverage-e2e names tide.ts:99 uncovered; the zero is the never-reachedoptions.initial ?? await getPullfallback on line 98 #466, so the 99 % branch floor holds with or without refactor(approve, meow): drop the three dead arms left open on #466 #497.Related Issue
Closes #499
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88