Skip to content

fix(contacts): handle CHECKSUM_DRIFT from GetFlipcashContacts #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 1, 2026
Merged

fix(contacts): handle CHECKSUM_DRIFT from GetFlipcashContacts #818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions .../flipcash/shared/contacts/src/main/kotlin/com/flipcash/app/contacts/ContactCoordinator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ class ContactCoordinator @Inject constructor(
)

// 6. GetFlipcashContacts
fetchFlipcashContacts(newChecksum)
fetchFlipcashContacts(newE164s, newChecksum)

_state.update { it.copy(syncState = SyncState.Synced, hasEverSynced = true) }
trace(tag = TAG, message = "Contact sync complete", type = TraceType.Process)
Expand Down Expand Up @@ -465,7 +465,11 @@ class ContactCoordinator @Inject constructor(
)
}

private suspend fun fetchFlipcashContacts(checksum: Checksum) {
private suspend fun fetchFlipcashContacts(
e164s: Set<String>,
checksum: Checksum,
retried: Boolean = false,
) {
try {
val result = contactListController.getFlipcashContacts(checksum)
.firstOrNull()
Expand All @@ -483,12 +487,24 @@ class ContactCoordinator @Inject constructor(
_state.update { it.copy(flipcashE164s = flipcashE164s) }
trace(tag = TAG, message = "Found ${flipcashE164s.size} contacts on Flipcash", type = TraceType.Process)
}?.onFailure { error ->
if (error is GetContactsError.NotFound) {
contactDataSource.clearFlipcashStatus()
_state.update { it.copy(flipcashE164s = emptySet()) }
trace(tag = TAG, message = "No contacts on Flipcash yet", type = TraceType.Process)
} else {
trace(tag = TAG, message = "GetFlipcashContacts failed: ${error.message}", type = TraceType.Error)
when (error) {
is GetContactsError.NotFound -> {
contactDataSource.clearFlipcashStatus()
_state.update { it.copy(flipcashE164s = emptySet()) }
trace(tag = TAG, message = "No contacts on Flipcash yet", type = TraceType.Process)
}
is GetContactsError.ChecksumDrift -> {
if (!retried) {
trace(tag = TAG, message = "GetFlipcashContacts checksum drift, performing full upload and retrying", type = TraceType.Process)
performFullUpload(e164s, checksum)
fetchFlipcashContacts(e164s, checksum, retried = true)
} else {
trace(tag = TAG, message = "GetFlipcashContacts checksum drift persisted after retry", type = TraceType.Error)
}
}
else -> {
trace(tag = TAG, message = "GetFlipcashContacts failed: ${error.message}", type = TraceType.Error)
}
}
}
} catch (e: Exception) {
Expand Down
Loading