refactor(ui): extract shared AmountEntryScreen and AmountEntryDelegate#829
Merged
Conversation
github-actions
Bot
added
type: refactor
Extract duplicated amount-entry UI and ViewModel logic into a shared
module (apps/flipcash/shared/amount-entry). The new AmountEntryDelegate
encapsulates NumberInputHelper, currency observation, and animated model
management. The new AmountEntryScreen composable provides the unified
Column { AmountWithKeypad + CodeButton/SlideToConfirm } layout.
Migrated Cash (Give), Swap (Buy/Sell), and Withdrawal features to use
the shared components, eliminating ~250 lines of duplicated code.
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
…Delegate AmountEntryDelegate now derives AmountEntryConfig internally from style, loadingState, maxAmount, and minimumAmount flows passed at construction. VMs provide structured AmountEntryStyle inputs instead of owning a secondary config StateFlow, eliminating the only instance of a secondary StateFlow on any BaseViewModel in the codebase. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
force-pushed
the
refactor/shared-amount-entry
branch
2 times, most recently
from
3dc825f to
fa75fbd
Compare
…estability AmountEntryDelegate now implements AmountEntryController, which captures the screen-facing API (state, config, keypad input). AmountEntryScreen takes the interface instead of the concrete class, enabling Compose UI tests with a trivial FakeController — no Exchange mock, coroutine scope, or flow wiring required. Adds 10 Robolectric Compose UI tests covering action labels, enabled state, loading transitions, confirm callback, slide variant, hints, and keypad forwarding. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
force-pushed
the
refactor/shared-amount-entry
branch
from
fa75fbd to
e319a6b
Compare
…, and WithdrawalConfirmation Add Robolectric-based Compose UI tests following the established pattern from AmountEntryScreenTest. Includes receipt, currency conversion, and bonding curve token rendering tests. Extract compose-ui-testing bundle and enable isIncludeAndroidResources globally in the convention plugin. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
…Model API Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
Gradle 9 fails test tasks when test dependencies exist but no test classes are discovered. Set failOnNoDiscoveredTests to false in the convention plugin since kotlin-test-junit is added to all modules.
Keep refactored AmountEntryScreen usage, discard old AmountWithKeypad inline implementation that was replaced by the shared module.
github-actions
Bot
added
area: onramp
Include :libs:test-utils as a testImplementation dependency in the base library convention plugin so all modules pick up the robolectric.properties file pinning SDK to 36. Remove the now-redundant manual declarations from 15 individual modules.
bmc08gt
force-pushed
the
refactor/shared-amount-entry
branch
from
a058b94 to
e9bc21d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract duplicated amount-entry UI and ViewModel logic into a shared module (apps/flipcash/shared/amount-entry). The new AmountEntryDelegate encapsulates NumberInputHelper, currency observation, and animated model management. The new AmountEntryScreen composable provides the unified Column { AmountWithKeypad + CodeButton/SlideToConfirm } layout.
Migrated Send, Cash (Give), Swap (Buy/Sell), and Withdrawal features to use the shared components, eliminating ~250 lines of duplicated code.