fix: resolve Windows build/check crash and npm shrinkwrap registry 404#29
Open
SHJordan wants to merge 1 commit into
Open
fix: resolve Windows build/check crash and npm shrinkwrap registry 404#29SHJordan wants to merge 1 commit into
SHJordan wants to merge 1 commit into
Conversation
- Fix scripts/build-all.mjs and scripts/run-web-ui-check.mjs to execute native package manager binaries directly instead of passing them to node on Windows. - Fix generate-coding-agent-shrinkwrap.mjs to mark internal workspace dependencies with inBundle: true and avoid registry resolution paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
Windows build/check crash:
scripts/build-all.mjsandscripts/run-web-ui-check.mjs, the script was trying to evaluate native binaries (such aspnpm.exeon Windows, which is set innpm_execpathby newer pnpm installations) using Node.js, causing aSyntaxError. We fixed this by detecting if the execpath does not end in.js/.cjs(which indicates a native binary) and running it directly instead of wrapping it via Node.Package shrinkwrap dependency registry 404 error:
npm-shrinkwrap.jsonfor@code-yeongyu/senpicontained registry references to internal, private workspace packages (like@earendil-works/pi-tui) which are bundled but not actually published to the public registry. This resulted in404 Not Founderrors when users tried to install@code-yeongyu/senpi.scripts/generate-coding-agent-shrinkwrap.mjsto mark internal dependencies as"inBundle": trueand omitresolvedURL registry references, forcing npm to resolve them from the bundled contents.Summary by cubic
Fixes Windows build/check crashes by executing native package manager binaries directly. Also updates shrinkwrap generation to bundle internal packages, avoiding registry 404s when installing
@code-yeongyu/senpi.execpath(e.g.,pnpm.exe) and run it directly in build/check scripts; otherwise load.js/.cjsvia Node.@earendil-works/pi-agent-core,@earendil-works/pi-ai,@earendil-works/pi-tui) as"inBundle": trueand omitresolvedURLs in the generatednpm-shrinkwrap.json.Written for commit 5e3d7d1. Summary will update on new commits.