Skip to content

fix: resolve Windows build/check crash and npm shrinkwrap registry 404 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SHJordan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve Windows build/check crash and npm shrinkwrap registry 404 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/coding-agent/npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions scripts/build-all.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ export function cleanEnv(envSource = process.env) {
function spawnPmAsync(pm, args, cwd, env) {
// bun's execpath is a native binary so we invoke it directly.
// npm's and pnpm's execpaths are .js / .cjs entry points that have to
// be loaded through the current Node runtime.
// be loaded through the current Node runtime, unless they are native binaries (like pnpm.exe).
let command = pm.cmd;
let spawnArgs = args;
if (pm.execpath && pm.cmd === "bun") {
if (pm.execpath && (pm.cmd === "bun" || !/\.[cm]?js$/i.test(pm.execpath))) {
command = pm.execpath;
} else if (pm.execpath) {
command = process.execPath;
Expand Down
3 changes: 2 additions & 1 deletion scripts/generate-coding-agent-shrinkwrap.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ function sortedPackageEntry(entry) {
"version",
"resolved",
"integrity",
"inBundle",
"license",
"dependencies",
"optionalDependencies",
Expand Down Expand Up @@ -196,7 +197,7 @@ function addInternalWorkspace(shrinkwrapPackages, addedPaths, queue, name, works
const packageJson = workspace.packageJson;
const outputPath = `node_modules/${name}`;
const entry = copyPackageJsonEntry(packageJson, { includeName: false });
entry.resolved = registryTarballUrl(name, packageJson.version);
entry.inBundle = true;

shrinkwrapPackages[outputPath] = sortedPackageEntry(entry);
addedPaths.add(outputPath);
Expand Down
4 changes: 2 additions & 2 deletions scripts/run-web-ui-check.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ function detectPm() {
}

const pm = detectPm();
// bun's execpath is a native binary, npm/pnpm are .js we load via Node.
// bun's execpath is a native binary, npm/pnpm are .js we load via Node, unless they are native binaries (like pnpm.exe).
function runCheck() {
if (pm.execpath && pm.cmd === "bun") {
if (pm.execpath && (pm.cmd === "bun" || !/\.[cm]?js$/i.test(pm.execpath))) {
return spawnSync(pm.execpath, ["run", "check"], { cwd: webUiDir, stdio: "inherit", env, shell: false });
}
if (pm.execpath) {
Expand Down