All done with Lab01#7
Open
dataluxe wants to merge 2 commits into
Open
Conversation
Lab Complete
izzybaer
reviewed
Nov 28, 2017
| return (typeof a === 'number' && typeof b === 'number') ? a - b : null; | ||
| }; | ||
|
|
||
| module.exports = Arith; |
izzybaer
reviewed
Nov 28, 2017
| @@ -0,0 +1,9 @@ | |||
| 'use strict'; | |||
|
|
|||
| //const Greet = module.exports = {}; | |||
izzybaer
reviewed
Nov 28, 2017
| expect(arith.add(1847, 'wrong')).toBe(null); | ||
| }); | ||
|
|
||
| test('Testing arithmetic > sub function [positive case].', () => { |
There was a problem hiding this comment.
to be more descriptive you could have a describe block that says( 'testing arithmetic sub method') then test('it should return the product of a - b')
izzybaer
reviewed
Nov 28, 2017
| const greet = require(`../lib/greet`); | ||
|
|
||
| test('Testing greet > sayHi function.', () => { | ||
| expect(greet('world')).toBe('hello world'); |
There was a problem hiding this comment.
you don't always have to use toBe, you can also use toEqual, toBeTruthy, toBeFalsy, toMatch, toBeGreaterThan
izzybaer
reviewed
Nov 28, 2017
|
|
||
| In 'greet.js', per the instructions, I returned a single function, sayHi(), which appends 'hello ' to the front of a string provided by the user... and, if the user send in input other than of Type 'string', it returns 'null'. | ||
|
|
||
| In 'greet.js', per the instructions, I returned an Object, "Arith" with two functions within it; add() adds the two provided numbers together, and sub() subtracts them. In both functions, if either of the input values provided are not of Type 'number', I return 'null'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.