Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lab-phelan/.eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
**/node_modules/*
**/vendor/*
**/*.min.js
**/coverage/*
**/build/*
26 changes: 26 additions & 0 deletions lab-phelan/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"env": {
"browser": true,
"node": true,
"commonjs": true,
"jest": true,
"es6": true
},
"globals": {
"err": true,
"req": true,
"res": true,
"next": true
},
"extends": "eslint:recommended",
"parserOptions": {
"sourceType": "module"
},
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": ["error", "single", { "allowTemplateLiterals": true }],
"comma-dangle": ["error", "always-multiline"],
"semi": [ "error", "always" ]
}
}
80 changes: 80 additions & 0 deletions lab-phelan/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@

# Created by https://www.gitignore.io/api/node,linux

### Linux ###
*~

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

### Node ###
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Typescript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env


# End of https://www.gitignore.io/api/node,linux
9 changes: 9 additions & 0 deletions lab-phelan/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
In /lib, i have two .js files - both enumerate CommonJS-style modules, and pin them to 'module.exports' at the very end of the file.

In 'greet.js', per the instructions, I returned a single function, sayHi(), which appends 'hello ' to the front of a string provided by the user... and, if the user send in input other than of Type 'string', it returns 'null'.

In 'greet.js', per the instructions, I returned an Object, "Arith" with two functions within it; add() adds the two provided numbers together, and sub() subtracts them. In both functions, if either of the input values provided are not of Type 'number', I return 'null'.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arithmetic.js


Easy.

Beans.
13 changes: 13 additions & 0 deletions lab-phelan/lib/arithmetic.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
'use strict';

const Arith = module.exports = {};

Arith.add = (a, b) => {
return (typeof a === 'number' && typeof b === 'number') ? a + b : null;
};

Arith.sub = (a, b) => {
return (typeof a === 'number' && typeof b === 'number') ? a - b : null;
};

module.exports = Arith;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant

9 changes: 9 additions & 0 deletions lab-phelan/lib/greet.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

//const Greet = module.exports = {};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corpse code


function sayHi (name) {
return typeof name === 'string' ? `hello ${name}` : null ;
}

module.exports = sayHi;
Loading