fix(client): resolve mypy type narrowing issue for cross encoder - #254
Merged
codeforstartups merged 1 commit intoSep 25, 2026
Merged
codeforstartups merged 1 commit into
codeforstartups merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Resolved a strict type-checking issue identified by
mypyin_cross_encoder_rerank(client.py).The instance variable
self._cross_encoderwas typed as potentiallyNone, leadingmypyto throw aNone has no attribute predicterror since it couldn't guarantee that the instance variable wasn't mutated between the null check and the method call.Assigned it to a local variable
encoderfirst, ensuring safe type narrowing and preventing potential runtimeAttributeErrors in multi-threaded contexts.