Skip to content

fix(client): resolve mypy type narrowing issue for cross encoder #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeforstartups merged 1 commit into from
Sep 25, 2026
Merged

fix(client): resolve mypy type narrowing issue for cross encoder #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/dynavec/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,11 +722,13 @@ def _cross_encoder_rerank(
"rerank",
) from exc

if self._cross_encoder is None:
self._cross_encoder = CrossEncoder(self.config.cross_encoder_model)
encoder = self._cross_encoder
if encoder is None:
encoder = CrossEncoder(self.config.cross_encoder_model)
self._cross_encoder = encoder

pairs = [(query, result.text) for result in results]
scores = self._cross_encoder.predict(pairs)
scores = encoder.predict(pairs)

reranked = sorted(
zip(results, scores),
Expand Down
Loading