fix: make MariaDB version detection case-insensitive in tests#10208
fix: make MariaDB version detection case-insensitive in tests#10208jalexiscv wants to merge 1 commit into
Conversation
Fixes codeigniter4#7929 The tests used str_contains() for MariaDB version detection, which is case-sensitive. On some MariaDB installations, the version string returned by server_info may have different casing, causing the detection to fail. Also updated GetVersionTest regex to accept MariaDB version format '10.11.4-MariaDB-1' which includes a suffix after the numeric version. Changes: - ForgeTest: str_contains → str_contains(strtolower(...)) - GetFieldDataTestCase: str_contains → str_contains(strtolower(...)) - GetVersionTest: regex updated to match MariaDB version format Ref: codeigniter4#7929
|
Hi there, jalexiscv! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
| return ! ( | ||
| version_compare($this->db->getVersion(), '8.0.17', '>=') | ||
| && ! str_contains($this->db->getVersion(), 'MariaDB') | ||
| && ! str_contains(strtolower($this->db->getVersion()), strtolower('MariaDB')) |
There was a problem hiding this comment.
No need to convert the string, edit as mariadb
| ]; | ||
|
|
||
| if (version_compare($this->db->getVersion(), '8.0.17', '>=') && ! str_contains($this->db->getVersion(), 'MariaDB')) { | ||
| if (version_compare($this->db->getVersion(), '8.0.17', '>=') && ! str_contains(strtolower($this->db->getVersion()), strtolower('MariaDB'))) { |
There was a problem hiding this comment.
No need to convert the string, edit as mariadb
2 participants
Description
Fixes #7929 - [MariaDB] phpunit test errors
Problem
Two test failures on MariaDB:
ForgeTest::testAddFields - Uses str_contains() for MariaDB version detection which is case-sensitive. On some MariaDB installations, the server_info version string may have different casing, causing MariaDB to be incorrectly treated as MySQL 8.0.17+, which sets max_length to null for integer fields. MariaDB still reports max_length for integer columns.
GetVersionTest::testGetVersion - The regex only matches plain numeric versions like 8.0.17, not MariaDB versions like 10.11.4-MariaDB-1.
Solution
ForgeTest + GetFieldDataTestCase
Replace str_contains($version, 'MariaDB') with case-insensitive comparison using strtolower()
GetVersionTest
Update the regex to accept versions with suffixes.
Changes
Ref: #7929
Closes #7929