Skip to content

fix: make MariaDB version detection case-insensitive in tests #10208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jalexiscv wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −3
Open

fix: make MariaDB version detection case-insensitive in tests #10208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/system/Database/Live/ForgeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ public function testAddFields(): void
],
];

if (version_compare($this->db->getVersion(), '8.0.17', '>=') && ! str_contains($this->db->getVersion(), 'MariaDB')) {
if (version_compare($this->db->getVersion(), '8.0.17', '>=') && ! str_contains(strtolower($this->db->getVersion()), strtolower('MariaDB'))) {
Copy link
Copy Markdown
Contributor

@neznaika0 neznaika0 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to convert the string, edit as mariadb

// As of MySQL 8.0.17, the display width attribute for integer data types
// is deprecated and is not reported back anymore.
// @see https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html
Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Live/GetVersionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ public function testGetVersion(): void

$version = $this->db->getVersion();

$this->assertMatchesRegularExpression('/\A\d+(\.\d+)*\z/', $version);
$this->assertMatchesRegularExpression('/\A\d+(\.\d+)+\-?/', $version);
}
}
2 changes: 1 addition & 1 deletion tests/system/Database/Live/MySQLi/GetFieldDataTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private function isOldMySQL(): bool
{
return ! (
version_compare($this->db->getVersion(), '8.0.17', '>=')
&& ! str_contains($this->db->getVersion(), 'MariaDB')
&& ! str_contains(strtolower($this->db->getVersion()), strtolower('MariaDB'))
Copy link
Copy Markdown
Contributor

@neznaika0 neznaika0 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to convert the string, edit as mariadb

);
}

Expand Down