Skip to content

fix: give the theme commands a longer timeout - #45

Merged
marevol merged 2 commits into
mainfrom
fix/theme-remote-timeout
Oct 16, 2026
Merged

marevol merged 2 commits into
mainfrom
fix/theme-remote-timeout

Conversation

@marevol

@marevol marevol commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

fessctl theme available and theme install make the Fess server call the remote theme repository (and download the archive for install) while serving the request. The 5 second default client timeout is too short for that: the integration test for available timed out on CI runners. Both commands now use a 60 second timeout.

Test plan

  • Unit test asserts both commands construct the client with a timeout of at least 60 seconds.
  • uv run pytest tests/unit: all pass.

This PR also drops the branches filter from the pull_request trigger of run-tests.yml: it was limited to main, so pull requests stacked on another branch got no checks. Pushes are still limited to main.


Stacked PRs (merge from the bottom; each PR's base is the branch below it, so no conflicts remain):
main ← #45 theme timeout (+ CI runs for stacked PRs) ← #46 typer ← #43 ops commands ← #44 dict ← #41 general/plugin/storage ← #42 searchlist/documents.
After a PR is squash-merged GitHub retargets the next one to main.

`theme available` and `theme install` make Fess reach the remote theme
repository while handling the request, which regularly exceeds the 5
second default client timeout (CI failed with "Network error: timed
out" on the available-themes test). Use a 60 second timeout for both.
The pull_request trigger was limited to main, so a pull request stacked
on another branch got no checks. Drop the branch filter; pushes are
still limited to main, so a branch push does not build twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant