Repository navigation
fix: upgrade typer so required arguments and options are enforced - #46
Merged
Merged
Conversation
With the locked click 8.3.0, typer 0.16.0 no longer rejects a missing required argument or option: the value arrives as None and is sent to the API (for example `theme install foo` posts a null version and `webconfig create` without --name reaches the server). typer 0.20.0 handles click 8.3 correctly, so a missing parameter is a usage error (exit code 2) again. Add a unit test for it. The full suite passes against Fess 15.9.0, 15.8.0, 15.7.0, 15.6.1 and 14.19.2.
This was referenced Oct 16, 2026
CI forces colour output, which splits the option name with escape sequences and made the assertion on the usage error text fail there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv.lockpins click 8.3.0, and with typer 0.16.0 a missing required argument or option is not rejected: the value arrives asNoneand is sent to the API. For examplefessctl theme install fooposts a null version, andfessctl webconfig createwithout--nameonly fails on the server side. Upgrading typer to 0.20.0 (which supports click 8.3) restores the usage error (exit code 2).Test plan
--name/VERSIONexits with code 2 and sends no request.Stacked PRs (merge from the bottom; each PR's base is the branch below it, so no conflicts remain):
main← #45 theme timeout (+ CI runs for stacked PRs) ← #46 typer ← #43 ops commands ← #44 dict ← #41 general/plugin/storage ← #42 searchlist/documents.After a PR is squash-merged GitHub retargets the next one to
main.