Update action-gh-release; make find/xargs safe for unusual filenames#2
Open
mattgodbolt wants to merge 1 commit into
Open
Update action-gh-release; make find/xargs safe for unusual filenames#2mattgodbolt wants to merge 1 commit into
mattgodbolt wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds automated linting for GitHub Actions workflows using actionlint, aligning this repository with the org-wide rollout, and updates existing workflows to satisfy actionlint checks.
Changes:
- Added a new workflow to run
actionlinton pushes/PRs that modify workflow files or theactionlintconfig. - Added
.github/actionlint.yamlto configure runner labels and gate shellcheck info/style findings. - Updated existing workflows (bump
softprops/action-gh-releasetov2and fixedfind | xargsusage to avoid SC2038).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/test-windows.yml | Bumps softprops/action-gh-release to v2 for releases built from tags. |
| .github/workflows/lint-actions.yml | Adds a workflow that runs actionlint when workflow/config files change. |
| .github/workflows/code-quality.yml | Updates `find … |
| .github/actionlint.yaml | Adds repo-local actionlint configuration (runner labels + shellcheck gating). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+10
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: ['.github/workflows/**', '.github/actionlint.yaml'] | ||
| pull_request: | ||
| paths: ['.github/workflows/**', '.github/actionlint.yaml'] | ||
|
|
||
| jobs: |
Comment on lines
223
to
226
| - name: Upload release assets | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| uses: softprops/action-gh-release@v1 | ||
| uses: softprops/action-gh-release@v2 | ||
| with: |
Member
Author
There was a problem hiding this comment.
Fair hardening idea, but out of scope for this version bump: the release workflow already succeeds under this repo's current default token permissions, and v1→v2 of action-gh-release doesn't change what it needs. Declaring explicit permissions: contents: write is a reasonable follow-up if org defaults ever tighten.
- softprops/action-gh-release v1 -> v2 - code-quality.yml: find ... -print0 Found by an org-wide actionlint sweep; the lint tooling itself is staying in the core repos only, but these fixes stand on their own. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mattgodbolt
changed the title
mattgodbolt
force-pushed
the
add-actionlint
branch
from
85fbaf3 to
46bd759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by an org-wide actionlint sweep. Per review feedback the lint tooling itself is staying in the core repos (compiler-explorer, infra, compiler-workflows) — this PR keeps just the fixes, which stand on their own:
🤖 Generated with Claude Code