Skip to content

Update action-gh-release; make find/xargs safe for unusual filenames #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattgodbolt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update action-gh-release; make find/xargs safe for unusual filenames #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,12 @@ jobs:
echo "✅ All headers have proper include guards"

echo "=== Checking for TODO comments ==="
TODO_COUNT=$(find src/ include/ -name "*.cpp" -o -name "*.hpp" | xargs grep -i "todo:" | wc -l || echo "0")
TODO_COUNT=$(find src/ include/ \( -name "*.cpp" -o -name "*.hpp" \) -print0 | xargs -0 grep -i "todo:" | wc -l || echo "0")
echo "TODO comments found: $TODO_COUNT"

if [ "$TODO_COUNT" -gt 0 ]; then
echo "📝 TODO comments:"
find src/ include/ -name "*.cpp" -o -name "*.hpp" | xargs grep -n -i "todo:" || true
find src/ include/ \( -name "*.cpp" -o -name "*.hpp" \) -print0 | xargs -0 grep -n -i "todo:" || true
fi


Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ jobs:

- name: Upload release assets
if: startsWith(github.ref, 'refs/tags/')
uses: softprops/action-gh-release@v1
uses: softprops/action-gh-release@v2
with:
Comment on lines 223 to 226

@mattgodbolt mattgodbolt Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair hardening idea, but out of scope for this version bump: the release workflow already succeeds under this repo's current default token permissions, and v1→v2 of action-gh-release doesn't change what it needs. Declaring explicit permissions: contents: write is a reasonable follow-up if org defaults ever tighten.

files: |
ce-win-file-cache-${{ github.ref_name }}-windows-x64.zip
Expand Down
Loading