Skip to content

Update deprecated actions (docker/login-action v1 -> v3, checkout v3 -> v4) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattgodbolt merged 1 commit into from
Jul 12, 2026
Merged

Update deprecated actions (docker/login-action v1 -> v3, checkout v3 -> v4) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ jobs:
runs-on: windows-2022
steps:
- name: Docker Login
uses: docker/login-action@v1
uses: docker/login-action@v3
Comment on lines 9 to +11

@mattgodbolt mattgodbolt Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declining — this is valid YAML. Block sequence entries may sit at the same indentation column as their parent mapping key (a "zero-indented" block sequence); it parses identically to the extra-indented form. This workflow has parsed and run in exactly this form for years, and actionlint — which uses a real YAML parser — passes it cleanly.

with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Build image
run: docker build -t compilerexplorer/windows:latest .
- name: Push to Docker Hub
Expand Down