Repository navigation
Create catalog proposals as signed commits - #34
Merged
Merged
Conversation
The master ruleset requires verified signatures, so a proposal committed locally with git commit-tree could never merge. The publication helper now has GitHub create the catalog blob, tree and commit through the REST API with the job token, which GitHub signs. It requires the objects to match the locally computed tree and parent and the commit to be verified before pointing automation/plugin-catalog at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
masterruleset requires verified signatures, so a catalog proposal built locally withgit commit-tree(#33) could never merge. The tap hit the same block in computer-mcp/homebrew-tap#6.The publication helper now computes the expected tree locally as before, then has GitHub create the catalog blob, tree and commit through the REST API with the job token, which GitHub signs. It requires GitHub's blob and tree to match the local objects and the commit to be verified, points
automation/plugin-catalogat it, and fetches it to confirm parent and tree before the merge step. The Pages job passes its token to that step; docs describe the signed proposal.Tests serve the same API calls from the bare fixture remote and cover a rejected unsigned commit and a missing token.