Skip to content

fix: move the rolling tag of the released major version #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 3 commits into from
Nov 4, 2026
Merged

fix: move the rolling tag of the released major version #521

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1205ea
fix: move the rolling tag of the released major version
shenxianpeng Nov 4, 2026
e267586
fix: take the release tag from ref on manual runs
shenxianpeng Nov 4, 2026
7fd5f4d
fix: check that the release tag is the checked out commit
shenxianpeng Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@ on:
types: [released]
workflow_dispatch:
inputs:
tag:
description: 'which tag to update to'
default: 'v2'
required: true
ref:
description: 'which branch to update the tag on'
default: 'main'
description: 'release tag to point the rolling tag at, e.g. v2.24.1'
required: true
tag:
description: 'rolling tag to update, e.g. v2 (blank = major version of ref)'
required: false

permissions:
contents: write
Expand All @@ -33,8 +31,28 @@ jobs:
- name: Update rolling tag
env:
INPUT_TAG: ${{ inputs.tag }}
INPUT_REF: ${{ inputs.ref }}
RELEASE_TAG: ${{ github.event.release.tag_name }}
run: |
# Use the tag given by hand, else the major version of the latest tag
TAG="${INPUT_TAG:-$(git tag --list --sort=-v:refname | head -n1 | cut -d. -f1)}"
# The rolling tag follows the major version of the published release
# (or the release tag given as ref), not of the newest tag in the
# repository: a v2 patch published after v3 must move v2, not v3.
RELEASE="${RELEASE_TAG:-$INPUT_REF}"
if ! [[ "$RELEASE" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "::error title=Not a release tag::'${RELEASE}' is not a vX.Y.Z release tag; give the release tag as ref"
exit 1
Comment thread
shenxianpeng marked this conversation as resolved.
Resolved
fi
MAJOR="${RELEASE%%.*}"
TAG="${INPUT_TAG:-$MAJOR}"
if [ "$TAG" != "$MAJOR" ]; then
echo "::error title=Major version mismatch::$TAG cannot point at $RELEASE"
exit 1
fi
# A branch named like the tag would be checked out instead of the tag
if [ "$(git rev-parse HEAD)" != "$(git rev-parse --verify --quiet "refs/tags/$RELEASE^{commit}")" ]; then
echo "::error title=Commit mismatch::tag $RELEASE is missing or not the checked out commit"
exit 1
fi
echo "Moving $TAG to $RELEASE ($(git rev-parse --short HEAD))"
git tag --force --annotate "$TAG" --message "Retag $TAG"
git push origin "$TAG" --force
Loading