Conversation
Three of the platform's settings appear in the alternative installation: the deprovision flag in the two settings files and the config template, the logging mode in the compose environment and the podman run line, and the settings file variable the build passes to collectstatic. ctrliq/ascender#998 gives all three the Ascender name. The AWX names keep answering: the two file-defined ones through the alias table in production.py, and the environment one because the platform reads both, which it has to since that variable decides which settings file loads at all. So this is a move rather than a fix, and unlike the awx.main imports it does not have to wait for a release: an older Ascender still reads the AWX names, and this repository writes the Ascender ones only where the new platform reads them. Worth landing with the release that carries #998 all the same, since there is nothing to gain from being early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of the platform's settings appear in the
alternative/installation:AWX_AUTO_DEPROVISION_INSTANCES, in the two settings files and the config templateAWX_LOGGING_MODE, in the compose environment, the podman run line and the environment templateAWX_SETTINGS_FILE, which the build passes tocollectstaticctrliq/ascender#998 gives all three the Ascender name.
Why this one does not have to wait for a release
The AWX names keep answering: the two file-defined ones through the alias table in
production.py, andAWX_SETTINGS_FILEbecause the platform reads both names directly. It has to, since that variable decides which settings file loads at all, and an alias applied after the settings modules load would be too late.That is different from the
awx.mainimports in #247, where the new name simply does not resolve on an older Ascender. Here an older Ascender still reads the AWX names and a newer one reads both.Worth landing with the release that carries #998 all the same, since there is nothing to gain from being early.
Checking
Seven lines, listed in full in the diff. The compose file parses as YAML, the podman script passes
bash -n, and both settings files parse as Python.