Repository navigation
Conversation
A column's label defaults to its name, so compileSQLTable blanked the type whenever the two matched, including when the label was set explicitly (date: date). Record explicit labels and only blank the type when there is none. Fixes d2lang#1960
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1960
date: datein asql_tablerendered the column with an empty type. A column'slabel defaults to its name, so the compiler blanked the type whenever the two
matched, even when the label was written explicitly.
The compiler now records which labels were set explicitly and only blanks the
type for columns without one. This also covers a label and its constraint
written in separate statements:
shape: classhas the same check incompileClass. That case is tracked in #2951.