Repository navigation
Conversation
This reverts merge commit 62eda6c. galactic-gateway and galactic-nat crashloop at startup on every bonded edge host, taking the edge datapath down on both staging labs: xdpmode: read device of bonding_masters: lstat /sys/class/net/bonding_masters/device: not a directory xdpmode.Select walks every entry in /sys/class/net. With the bonding module loaded, bonding_masters is a regular file there, so the Lstat of bonding_masters/device fails with ENOTDIR. interfaceDriver only treats ENOENT as "not a physical NIC", so the error is fatal. The unit-test sysfs fixture holds only interface directories, and CI hosts do not load bonding, so nothing exercised the file. Related to #673
4 tasks
scotwells
approved these changes
Oct 13, 2026
Collaborator
Author
|
Superseded by #854, which fixes the startup crash and keeps the Broadcom change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #852 merged, the edge gateway and NAT crash at startup on every host with bonded uplinks, so both staging labs have no edge datapath.
The new XDP mode check reads every entry in the host's sysfs interface list, and on a bonded host one entry is a plain file it treats as a fatal error.
This reverts #852 to the code both labs ran cleanly before it, and the Broadcom work can return once the check skips that file.
Test plan
Related to #673