Repository navigation
fix(xdp): Start the edge gateway and NAT on bonded hosts - #854
Merged
Merged
Conversation
galactic-gateway and galactic-nat crashloop at startup on every bonded edge host since #852: xdpmode: read device of bonding_masters: lstat /sys/class/net/bonding_masters/device: not a directory Select walks every entry in /sys/class/net. With the bonding module loaded, bonding_masters is a regular file there, so the Lstat of its device link fails with ENOTDIR, which interfaceDriver treats as fatal. Select now skips regular files; every interface in sysfs is a symlink. The test fixture adds bonding_masters to the bonded-host cases, which fail with the same error without this change. Related to #673
privateip
enabled auto-merge
October 13, 2026 00:17
scotwells
approved these changes
Oct 13, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #852 merged, the edge gateway and NAT crash at startup on every host with bonded uplinks, so both staging labs have no edge datapath.
The XDP mode check reads the host's sysfs interface list, where the bonding module adds one plain file beside the interfaces, and it treated that file as a broken interface.
The check now skips plain files, and the bonded-host tests include that file. This replaces the revert in #853.
Test plan
Related to #673