Repository navigation
GAM-3: let Video Creator file renders with their origin - #37
Merged
Merged
Conversation
POST /api/assets takes optional source, origin_project_id and origin_reference_id form fields. gvc_export is the only source a client may claim; the others are GAM's own statements about files it made. An origin without that source is refused. Two nullable columns on asset, origin_project_id indexed, returned on AssetRead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016fiRJAt34ag62iPiuMkNhm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAM-3 from gvc's plan of attack. GVC's "Save to GAM" (M2b) files a finished render into the user's library, labelled as a Video Creator export and linked back to the project it came from.
Change
POST /api/assetstakes three optional form fields:source;origin_project_id;origin_reference_id(the GVC render).gvc_exportis the only source a client may claim.ai_generated,clip,urlandsub_videodescribe files GAM made itself. A client able to set them could pass an upload off as, for example, a generation that the regenerate button then tries to rerun. Anything else gets400 invalid_source.source=gvc_exportgets400 origin_without_source.asset,origin_project_id(indexed) andorigin_reference_id;PRAGMA foreign_keyshandling asa8e1c0f4d2b6.AssetReadreturns both fields, and the frontend type has them;Tests
Backend
pytest -q: 1258 passed. New tests cover:The existing migration tests cover upgrade and downgrade on head.
Frontend:
npm test(393) andnpm run buildpass.🤖 Generated with Claude Code
https://claude.ai/code/session_016fiRJAt34ag62iPiuMkNhm
Generated by Claude Code