Repository navigation
feat: a missing column names the dataset's real columns - #11
Merged
Merged
Conversation
The column_not_found error gave only the dataset's column count. It now suggests up to three close matches (a case-only difference first, then by spelling) and lists the columns, capped at 50. The suggestions are also in a new `candidates` field on the JSON error, so an agent can correct the spec without parsing the message; the MCP tools share the resolver. Tests: seven offline cases, and the live check now resolves a deliberately misspelled column on 4.1.4, 5.0.0 and 6.1.0 and requires the real one as the first suggestion.
This was referenced Oct 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item B from the 0.2.0 triage.
Before:
groupby 'Region' not on dataset 'orders' (has 23 columns). An agent or a person had to look the dataset up in Superset to find the right name.After:
groupby 'Region' not on dataset 'orders'; did you mean 'region'? Columns: order_id, ordered_at, region, amount, status, and the JSON error carries"candidates": ["region"].SUM(amont)), and chart and filter-bar filter columns.candidatesis a new field on every resolution error (empty except forcolumn_not_found); existing fields are unchanged.check_specandbuild_dashboardreturn the same.Tests: seven offline cases in
tests/test_column_suggestions.py;tools/ci_live_check.pynow resolves a deliberately misspelled column against real Superset 4.1.4, 5.0.0 and 6.1.0 and requires the real column as the first suggestion.The guides in #9 that say the error gives a count will be updated there.
Offline suite: 354 passed.