fix: clippy errors#29
Merged
Merged
Conversation
Fix `clippy::unused_io_amount` errors in section_reader tests by using `read_exact`, remove an unused `offset_of` import, normalize an octal literal's digit grouping, and replace a `vec!` with an array in a test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VC2LkJTssLYaiHRzz23Kep
Remove redundant references in a format! argument in remove_version.rs, flagged by clippy::useless_borrows_in_formatting on the CI toolchain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VC2LkJTssLYaiHRzz23Kep
Tom Plant (pl4nty)
requested a review
from Russell Banks (russellbanks)
as a code owner
Tom Plant (pl4nty)
removed the request for review
from Russell Banks (russellbanks)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all clippy errors and warnings reported by
cargo clippy --all-targets(Rust 1.95).clippy::unused_io_amount(errors) insection_reader.rstests — replacedreadwithread_exact, slicing the buffer to the expected length where it was larger than the section.std::mem::offset_offrom thefooter.rstest module (the constant it backs is used, but the macro isn't referenced directly in tests).clippy::unusual_byte_groupings— normalized the octal literal0o1200_00to0o120_000ingit_file_mode.rs.clippy::useless_vec— replaced avec!with an array literal in azip.rstest.Verification
cargo clippy --all-targetsnow finishes clean with no errors or warnings.Generated by Claude Code