fix: clippy errors

src/analysis/installers/advanced/footer.rs

@@ -121,8 +121,6 @@ impl fmt::Debug for Footer {
 
 #[cfg(test)]
 mod tests {
-    use std::mem::offset_of;
-
     use super::Footer;
 
     #[test]

src/analysis/installers/pe/resource/section_reader.rs

@@ -213,12 +213,12 @@ mod tests {
         // Jump to middle
         reader.seek(SeekFrom::Start(20)).unwrap();
         let mut buf = [0u8; 1];
-        reader.read(&mut buf).unwrap();
+        reader.read_exact(&mut buf).unwrap();
         assert_eq!(buf[0], 30); // 10 + 20
 
         // Relative jump backwards
         reader.seek(SeekFrom::Current(-10)).unwrap();
-        reader.read(&mut buf).unwrap();
+        reader.read_exact(&mut buf).unwrap();
         assert_eq!(buf[0], 21); // 10 + 11 (position after previous read was 21)
 
         // Jump beyond end (should clamp)
@@ -242,11 +242,11 @@ mod tests {
 
         // Section at file boundaries
         let mut start_reader = SectionReader::new(Cursor::new(create_test_data()), 0, 5).unwrap();
-        start_reader.read(&mut buf).unwrap();
+        start_reader.read_exact(&mut buf[..5]).unwrap();
         assert_eq!(&buf[..5], &[0, 1, 2, 3, 4]);
 
         let mut end_reader = SectionReader::new(Cursor::new(create_test_data()), 95, 5).unwrap();
-        end_reader.read(&mut buf).unwrap();
+        end_reader.read_exact(&mut buf[..5]).unwrap();
         assert_eq!(&buf[..5], &[95, 96, 97, 98, 99]);
     }
 }

src/analysis/installers/zip.rs

@@ -371,7 +371,7 @@ mod tests {
     fn selected_nested_files_reject_invalid_file_with_valid_extension() -> Result<()> {
         let zip_bytes = zip_with_files(&[("valid.ttf", &TTF_SIGNATURE), ("invalid.ttf", b"nope")])?;
         let mut zip = Zip::new(Cursor::new(zip_bytes))?;
-        let selected_files = vec![
+        let selected_files = [
             Utf8PathBuf::from("valid.ttf"),
             Utf8PathBuf::from("invalid.ttf"),
         ];

src/commands/remove_version.rs

@@ -117,7 +117,7 @@ impl RemoveVersion {
             Some(reason) => reason,
             None => Text::new(&format!(
                 "Give a reason for removing {} version {}",
-                &self.package_identifier, &self.package_version
+                self.package_identifier, self.package_version
             ))
             .with_validator(MinLengthValidator::new(Self::MIN_REASON_LENGTH))
             .with_validator(MaxLengthValidator::new(Self::MAX_REASON_LENGTH))

src/github/rest/tree/git_file_mode.rs

@@ -110,7 +110,7 @@ mod tests {
     #[case::executable(GitFileMode::Executable, 0o100_755)]
     #[case::directory(GitFileMode::Directory, 0o040_000)]
     #[case::submodule(GitFileMode::Submodule, 0o160_000)]
-    #[case::symlink(GitFileMode::Symlink, 0o1200_00)]
+    #[case::symlink(GitFileMode::Symlink, 0o120_000)]
     fn git_file_mode_to_u16(#[case] git_file_mode: GitFileMode, #[case] expected: u16) {
         assert_eq!(u16::from(git_file_mode), expected);
         assert_eq!(u16::from(git_file_mode), git_file_mode as u16);