systest/vector: poll for HNSW index readiness instead of fixed sleeps#9739
Open
matthewmcneely wants to merge 1 commit into
Open
systest/vector: poll for HNSW index readiness instead of fixed sleeps#9739matthewmcneely wants to merge 1 commit into
matthewmcneely wants to merge 1 commit into
Conversation
TestVectorIndexRebuilding, TestVectorIndexDropPredicate, and TestVectorIndexWithoutSchema slept a fixed 5s after SetupSchema and assumed the HNSW index was ready. Rebuilding the index over pre-existing data is asynchronous, so the fixed sleep flaked on slower CI runners. Replace the sleeps with require.Eventually polling a sample similar_to query until it returns the expected result count (30s budget, 500ms interval). Also move `defer cleanup()` after the Client() error check in three tests so a cleanup from a failed Client() isn't deferred. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
area/testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TestVectorIndexRebuilding,TestVectorIndexDropPredicate, andTestVectorIndexWithoutSchemaslept a fixed 5s afterSetupSchemaand then asserted on the vector index. Rebuilding the HNSW index over pre-existing data is asynchronous, so the fixed sleep was flaky on slower CI runners — the index often wasn't ready when the assertion ran.Change
time.Sleepcalls withrequire.Eventually, polling a samplesimilar_toquery until it returns the expected result count (30s budget, 500ms interval).defer cleanup()after theClient()error check in three tests, so a cleanup from a failedClient()isn't deferred.Test-only change; no production code touched.