Skip to content

systest/vector: poll for HNSW index readiness instead of fixed sleeps #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewmcneely wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −5
Open

systest/vector: poll for HNSW index readiness instead of fixed sleeps #9739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions systest/vector/vector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,14 @@ func TestVectorIndexRebuilding(t *testing.T) {
// drop index
require.NoError(t, gc.SetupSchema(testSchemaWithoutIndex))

time.Sleep(5 * time.Second)
// rebuild index
require.NoError(t, gc.SetupSchema(testSchema))
time.Sleep(5 * time.Second)

// Rebuilding the HNSW index over pre-existing data is async; poll until ready.
require.Eventually(t, func() bool {
res, err := gc.QueryMultipleVectorsUsingSimilarTo(vectors[0], pred, 100)
return err == nil && len(res) == 100
}, 30*time.Second, 500*time.Millisecond, "vector index not ready after 30s")

result, err = gc.Query(query)
require.NoError(t, err)
Expand Down Expand Up @@ -309,8 +313,8 @@ func TestVectorIndexDropPredicate(t *testing.T) {
require.NoError(t, c.Start())

gc, cleanup, err := c.Client()
defer cleanup()
require.NoError(t, err)
defer cleanup()

require.NoError(t, gc.LoginIntoNamespace(context.Background(),
dgraphapi.DefaultUser, dgraphapi.DefaultPassword, x.RootNamespace))
Expand Down Expand Up @@ -365,6 +369,12 @@ func TestVectorIndexDropPredicate(t *testing.T) {
// add index back
require.NoError(t, gc.SetupSchema(testSchema))

// Rebuilding the HNSW index over pre-existing data is async; poll until ready.
require.Eventually(t, func() bool {
res, err := gc.QueryMultipleVectorsUsingSimilarTo(vectors[0], pred, 100)
return err == nil && len(res) == 100
}, 30*time.Second, 500*time.Millisecond, "vector index not ready after 30s")

result, err = gc.Query(query)
require.NoError(t, err)
require.JSONEq(t, fmt.Sprintf(`{"vector":[{"count":%v}]}`, numVectors), string(result.GetJson()))
Expand All @@ -385,8 +395,8 @@ func TestVectorIndexWithoutSchema(t *testing.T) {
require.NoError(t, c.Start())

gc, cleanup, err := c.Client()
defer cleanup()
require.NoError(t, err)
defer cleanup()

require.NoError(t, gc.LoginIntoNamespace(context.Background(),
dgraphapi.DefaultUser, dgraphapi.DefaultPassword, x.RootNamespace))
Expand All @@ -401,6 +411,14 @@ func TestVectorIndexWithoutSchema(t *testing.T) {

require.NoError(t, gc.SetupSchema(testSchema))

// Building the HNSW index over pre-existing nodes is async. Poll a
// sample query until the index is ready rather than sleeping a fixed
// duration, which is unreliable on slower CI runners.
require.Eventually(t, func() bool {
res, err := gc.QueryMultipleVectorsUsingSimilarTo(vectors[0], pred, 100)
return err == nil && len(res) == 100
}, 30*time.Second, 500*time.Millisecond, "vector index not ready after 30s")

for _, vect := range vectors {
similarVects, err := gc.QueryMultipleVectorsUsingSimilarTo(vect, pred, 100)
require.NoError(t, err)
Expand All @@ -427,8 +445,8 @@ func TestVectorIndexWithoutSchemaWithoutIndex(t *testing.T) {
require.NoError(t, c.Start())

gc, cleanup, err := c.Client()
defer cleanup()
require.NoError(t, err)
defer cleanup()

require.NoError(t, gc.LoginIntoNamespace(context.Background(),
dgraphapi.DefaultUser, dgraphapi.DefaultPassword, x.RootNamespace))
Expand Down
Loading