fix: fall back to GitHub for LFS downloads - #3419
Draft
Daniiiil1 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Daniil Mordanov <153565951+Daniiiil1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
The configured
lfs.dimensionalos.comendpoint can return 404 for objects that are still available from GitHub LFS. After retrying only the primary endpoint,get_data()raises and simulation startup fails. Users currently have to discover and persist a locallfs.urlworkaround themselves.Solution
After the existing primary-endpoint retries are exhausted, retry the same object once through the repository’s GitHub LFS endpoint using a per-command
git -c lfs.url=...override. This does not modify local or global Git configuration. If both endpoints fail, the exception reports both failures.Tests cover a successful fallback, the exact non-persistent command, and the combined-error path.
How to Test
I also verified the fallback endpoint against the known
cafe.jpg.tar.gzLFS object with:AI assistance
OpenAI Codex with GPT-5 assisted with codebase analysis, implementation, adversarial review, and test generation. The change is intentionally kept as a draft for final human review before requesting maintainer review.
Checklist
Closes #2495